Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transactions accelerated manually in Metamask are not picked up #184

Open
1bce2 opened this issue Jul 1, 2020 · 4 comments
Open

Transactions accelerated manually in Metamask are not picked up #184

1bce2 opened this issue Jul 1, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request tokens Issues that involve web3 or Solidity

Comments

@1bce2
Copy link

1bce2 commented Jul 1, 2020

Subject of the issue

Accelerated transactions are not recognized by the system - the document cannot be finalized

Your environment

Chrome OS 78.0.3904.108 / Metamask plugin

Steps to reproduce

After a document is purchased, sign transaction in Metamask pop-up, then open Metamask extension tab and choose "accelerate" and speed

Expected behaviour

System should recognize accelerated transactions like regular transactions

Actual behaviour

Transaction is not recognized - warning message ("do not quit this page") stays open, document is not finalized

@loleg
Copy link
Contributor

loleg commented Aug 14, 2020

@1bce2 thanks for raising the issue. We are transferring support responsibilities and will look into it.

@loleg loleg added the enhancement New feature or request label Aug 14, 2020
@loleg loleg added the tokens Issues that involve web3 or Solidity label Jan 5, 2022
@loleg
Copy link
Contributor

loleg commented Feb 16, 2023

There is no longer an "accelerate" option. When using a higher gas rate, the transaction succeeds more quickly. Therefore closing as we can no longer reproduce.

@tafonina
Copy link
Contributor

The problem is still actual - it is related to the fact that when you speed up transaction - in fact the 2nd transaction is created with the same nonce but with higher gas price value. Since the hash is calculated based on all of the parameters, it will differ from the first transaction, because the gas is different. Unfortunately, any wallets including MetaMask do not expose such APIs at the moment, so there is no way to catch this information in-app, from Metamask.
That's why user is not able to see real time update on his page now. In order to approach this problem properly - we have to delegate transaction listening to BE

https://betterprogramming.pub/how-to-listen-for-speed-up-and-canceled-transactions-on-ethereum-b2e850796e1c

The problem solution has high complexity and low priority, it doesn't lead to any bug or inconsistency - since when user jumps to the age with documents - he will see the confirmed document after successful transaction acceleration. The simple work around we can do also - adding some check - is transaction is pending for > x seconds (lets assume 60 or 120) - refresh the page

@loleg
Copy link
Contributor

loleg commented Jan 26, 2024

That's a great explanation of what is going on. Thanks for linking to the article - very technical, but it boils down to this picture:

I think right now this is not a priority for the project. We can add a note to the troubleshooting / FAQ, and encourage users who need a solution to fund it's development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tokens Issues that involve web3 or Solidity
Projects
Development

No branches or pull requests

3 participants