Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper Tool: Security Vulnerability #364

Closed
3 tasks done
NghiaTranUIT opened this issue Dec 29, 2019 · 1 comment
Closed
3 tasks done

Helper Tool: Security Vulnerability #364

NghiaTranUIT opened this issue Dec 29, 2019 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@NghiaTranUIT
Copy link
Member

NghiaTranUIT commented Dec 29, 2019

馃惗 Brief

There is a report from a dedicated user that Proxyman Helper Tool (PrivilegedHelperTools)could be exploited to change the System Proxy from unsigned apps.

Basically, it's the same issue with Little Snitch CVE-2019-13013 since Proxyman and Little Snitch use a same EvenBetterAuthorizationSample and we don't validate the codesign of incoming NSXPCConnection.

EvenBetterAuthorizationSample does good job to demonstrate how to install/uninstall the Help Tool and provide a mechanism to verify which app is authorized to do it. However, it doesn't validate the authenticity of the connections.

As a result, Any apps could exploited by sending the connection to Helper Tool, which has the same ExportProtocol.

We should fix it

馃憫 Criteria

  • Validate the codesign of connections before performing any System Change
  • Make sure one Helper Tool could verify and accept the Proxyman's Connection.
  • Use POC sample code to verify that the new Helper Tool will reject the unauthorized connections
@NghiaTranUIT NghiaTranUIT self-assigned this Dec 29, 2019
@NghiaTranUIT NghiaTranUIT added this to the Proxyman 1.12.0 馃攽 milestone Dec 29, 2019
@NghiaTranUIT NghiaTranUIT added the bug Something isn't working label Dec 29, 2019
@NghiaTranUIT
Copy link
Member Author

All done 馃尞
For any one concerns, her is the BETA build: https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_1.11.0_Security_Improve_Helper_Tool.dmg

It gonna release in the first week of 2020 馃憤

Changelogs

  • Validate the code-sign of connections before performing any System Change
  • Fix two instance of Helper Tool in app
  • Close the previous NSXPCConnection before upgrading

Screen Shot 2019-12-29 at 11 42 46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant