Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is it possible to allow installing atlantis on < iOS 12? #30

Closed
JohnnyTseng opened this issue Nov 4, 2020 · 4 comments
Closed

Is it possible to allow installing atlantis on < iOS 12? #30

JohnnyTseng opened this issue Nov 4, 2020 · 4 comments
Labels
Done This Ticket is done enhancement New feature or request
Milestone
Atlantis 1.3.0 🧰

Comments

@JohnnyTseng
Copy link

JohnnyTseng commented Nov 4, 2020 •
edited

Thanks for developing atlantis, however our project's deployment version is still iOS 11.
Is it possible to allow installing atlantis on < iOS 12?
Without functioning on older version is okay but only allow it to install (Maybe adding some #available flags?) on projects that deployment version are still on older versions
@NghiaTranUIT
Copy link
Member

Look like it’s possible because NSNetService and URLSessionStreamData both support iOS 11 👍

I will check out and support tomorrow if it’s possible

@NghiaTranUIT NghiaTranUIT mentioned this issue Nov 5, 2020
Merged
@NghiaTranUIT
Copy link
Member

NghiaTranUIT commented Nov 5, 2020 •
edited

@JohnnyTseng can you try this on your iOS 11 😄

pod 'atlantis-proxyman', :git => 'https://github.com/ProxymanApp/atlantis.git', :branch => 'support-ios-11'

I'm downloading the iOS 11 Simulator, but it might take a long time.

@NghiaTranUIT
Copy link
Member

hey @JohnnyTseng , this PR #31 is done.

Please installing:

pod 'atlantis-proxyman', :git => 'https://github.com/ProxymanApp/atlantis.git', :branch => 'support-ios-11'

it should work 👍

@NghiaTranUIT NghiaTranUIT added enhancement New feature or request Done This Ticket is done labels Nov 5, 2020
@NghiaTranUIT NghiaTranUIT added this to the Atlantis 1.3.0 🧰 milestone Nov 5, 2020
@JohnnyTseng
Copy link
Author

That's fast!! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Done This Ticket is done enhancement New feature or request
Projects
None yet
Milestone
Atlantis 1.3.0 🧰
Development

No branches or pull requests
2 participants
@JohnnyTseng @NghiaTranUIT