Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: out of mem after Requesting tags to be replaced #438

Merged
merged 2 commits into from
Jan 19, 2024
Merged

fix: out of mem after Requesting tags to be replaced #438

merged 2 commits into from
Jan 19, 2024

Conversation

MisterPresident
Copy link
Contributor

Fix #408 by skipping empty files.

@MisterPresident
Copy link
Contributor Author

#428

@guillaume-troadec
Copy link

Thanks! Do you think this is something that would fix #446 ?

@IOSure
Copy link

IOSure commented Oct 12, 2023

#408

@MisterPresident
Copy link
Contributor Author

Thanks! Do you think this is something that would fix #446 ?

Yes I think so.

@ShootingKing-AM ShootingKing-AM changed the title Fix out of mem after Requesting tags to be replaced... fix: out of mem after Requesting tags to be replaced Jan 19, 2024
@ShootingKing-AM ShootingKing-AM added the fix Fixed some bug/issue label Jan 19, 2024
@ShootingKing-AM
Copy link
Member

ShootingKing-AM commented Jan 19, 2024 •
edited

Cant reproduce the linked issues on my end, but it also makes sense to not scan empty files. Tests for this PR are done in #494
Thanks for the PR.

@ShootingKing-AM ShootingKing-AM merged commit 5720dee into ObsidianToAnki:master Jan 19, 2024
8 checks passed
@ShootingKing-AM ShootingKing-AM linked an issue Jan 19, 2024 that may be closed by this pull request
Anki sync paused before potential out-of-memory crash #428
Open
@MisterPresident
Copy link
Contributor Author

Cant reproduce the linked issues on my end, but it also makes sense to not scan empty files. Tests for this PR are done in #494 Thanks for the PR.

Thank you for merging.

How much .md files does your vault have? I guess it depends on the number of files. >1000?

@ShootingKing-AM
Copy link
Member

Cant reproduce the linked issues on my end, but it also makes sense to not scan empty files. Tests for this PR are done in #494 Thanks for the PR.

Thank you for merging.

How much .md files does your vault have? I guess it depends on the number of files. >1000?

Sorry, didnt see your message. Maybe we can write a Test for this. I definately will not have 1000 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShootingKing-AM ShootingKing-AM ShootingKing-AM left review comments

Assignees
No one assigned
Labels
fix Fixed some bug/issue
Projects
None yet
Milestone
No milestone
4 participants
@MisterPresident @guillaume-troadec @IOSure @ShootingKing-AM