chore: pass caller to add_record on every call #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b0xtch
changed the title
b0xtch
force-pushed
the
chore/add-caller-to-each-call
branch
from
03309a5
to
7b45a26
Compare
ferencdg
reviewed
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add_record used an Option on caller, cap_sdk expects a value for the param
caller.https://github.com/Psychedelic/cap/blob/85d135eb43433adef9b6681260ce64eaa5dbe48c/sdk/standards/src/dip20/cap.rs#L587
refer to link above.
if None is passed this will throw