Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor #58

Merged
merged 1 commit into from May 2, 2022
Merged

chore: refactor #58

merged 1 commit into from May 2, 2022

Conversation

scott-dn
Copy link
Contributor

@scott-dn scott-dn commented Apr 6, 2022

Why?

refactor.

How?

  • refactor

Tickets?

  • N/A

Contribution checklist?

  • The commit messages are detailed
  • It does not break existing features (unless required)
  • I have performed a self-review of my own code
  • Documentation has been updated to reflect the changes
  • Tests have been added or updated to reflect the changes
  • All code formatting pass
  • All lints pass
  • All tests pass

Security checklist?

  • Injection has been prevented (parameterized queries, no eval or system calls)
  • Sensitive data has been identified and is being protected properly

Demo?

Optionally, provide any screenshot, gif or small video.

@scott-dn scott-dn changed the title chore: apply import order chore: refactor Apr 6, 2022
@ozwaldorf ozwaldorf self-requested a review May 2, 2022 15:51
ozwaldorf
ozwaldorf approved these changes May 2, 2022
View reviewed changes
Copy link
Collaborator

@ozwaldorf ozwaldorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@scott-dn scott-dn merged commit 2fab174 into develop May 2, 2022
@scott-dn scott-dn deleted the chore/refactor branch May 2, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozwaldorf ozwaldorf ozwaldorf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@scott-dn @ozwaldorf