Rocky/add category field #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just noted that the csv already has a category field. I'll add other types and change the ones I used tomorrow :catsalute: |
Nima-Ra
reviewed
Oct 7, 2021
candid/registry.did
Outdated
| type canister_metadata = record { | ||
| name: text; | ||
| description: text; | ||
| url: text; | ||
| logo_url: text; | ||
| version: nat32; | ||
| category: canister_category |
candid/registry.did
Outdated
| }; | ||
|
|
||
| type input_canister_metadata = record { | ||
| name: text; | ||
| description: text; | ||
| url: text; | ||
| logo_url: text; | ||
| category: canister_category |
|
@Nima-Ra @rocky-fleek could merge this? |
qti3e
reviewed
Nov 3, 2021
| if let Ok((stable,)) = ic::stable_restore::<(StableStorageV0,)>() { | ||
| let data = get_data(); | ||
| let mut canister_list = Vec::with_capacity(stable.db.len()); | ||
| for (_key, canister_info) in stable.db.into_iter().enumerate() { |
There was a problem hiding this comment.
Unnecessary enumerate if you don't need the _key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added
categoryfield in canister metadata.The
categoryis one of 3 possible values (Asset, Nft, Service) and so I implemented it as an enum but I'm not sure if that's correct or not.@Nima-Ra I know I'm missing something on the upgrade script, cause I don't know how it would populate the fields otherwise. Just not sure how you do that to be honest