Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: IC-Token support stage 1 #38

Merged
merged 3 commits into from Oct 7, 2021
Merged

release: IC-Token support stage 1 #38

merged 3 commits into from Oct 7, 2021

Conversation

kanej
Copy link
Contributor

@kanej kanej commented Oct 7, 2021

This release adds functionality that will allow us to support https://github.com/dfinance-tech/ic-token

This will be a two stage process, with the old functions being retained but deprecated, while temporary new methods are added. In a future release, the final version of the IC-Token methods will be added, and the intermediary versions marked as deprecated.

kanej and others added 3 commits October 1, 2021 09:22
* chore(smoke): update verify to take into account fees

The fee change requires that the fee is included when calculating the balances.

* chore(smoke): add a user history listing function
* Increasing the history flush threshold to 4300000 
* Making Dank ERC-20 compatible 
* Configure github on develop branch
* Chore(smoke): add allowances section to manual tests

Co-authored-by: John Kane <john@kanej.me>
@coveralls
Copy link

coveralls commented Oct 7, 2021

Pull Request Test Coverage Report for Build 1316170549

  • 69 of 324 (21.3%) changed or added relevant lines in 9 files are covered.
  • 18 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-5.4%) to 55.563%

Changes Missing Coverage Covered Lines Changed/Added Lines %
xtc-history/xtc-history/src/lib.rs 0 3 0.0%
xtc-history/xtc-history-common/src/types.rs 0 5 0.0%
xtc/src/utils.rs 0 14 0.0%
xtc/src/meta.rs 0 19 0.0%
xtc/src/stats.rs 2 22 9.09%
xtc/src/history.rs 1 33 3.03%
xtc/src/ledger.rs 64 134 47.76%
xtc/src/common_types.rs 1 93 1.08%
Files with Coverage Reduction New Missed Lines %
xtc/src/history.rs 2 28.21%
xtc/src/ledger.rs 2 73.95%
xtc/src/meta.rs 2 0%
../../../github/home/.cargo/registry/src/github.com-1ecc6299db9ec823/num-bigint-0.4.2/src/biguint.rs 12 44.83%
Totals Coverage Status
Change from base Build 1265846663: -5.4%
Covered Lines: 1658
Relevant Lines: 2984

💛 - Coveralls

@kanej kanej merged commit f37cce4 into main Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants