Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(help): alter links in help menu #44

Merged
merged 2 commits into from Jul 6, 2021
Merged

Conversation

kanej
Copy link
Contributor

@kanej kanej commented Jul 6, 2021

This PR changes the help menu by:

  • Removing the review with plug option for the moment (we might bring it back when we have review pages)
  • Update the blog link to point at our medium page medium

Preview

image

kanej added 2 commits July 6, 2021 14:50
This may come back when we have a chrome review page we can point to.
@kanej kanej requested a review from heldrida July 6, 2021 14:00
Copy link
Member

@heldrida heldrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL links to "This publication does not have any stories yet.". I suppose it's a placeholder and should be alright to point to it.

@kanej
Copy link
Contributor Author

kanej commented Jul 6, 2021

The URL links to "This publication does not have any stories yet.". I suppose it's a placeholder and should be alright to point to it.

Good point. I will check with @nicolaspoggi

@ChriLnth
Copy link
Contributor

ChriLnth commented Jul 6, 2021

its missing the discord item

@kanej
Copy link
Contributor Author

kanej commented Jul 6, 2021

its missing the discord item

Good catch. I am going to separate that out into a different PR (as I don't know how we handle the discord logo).

@kanej
Copy link
Contributor Author

kanej commented Jul 6, 2021

I confirmed with @nicolaspoggi that the medium page is the correct link for the blog.

@kanej kanej merged commit 3165424 into develop Jul 6, 2021
@kanej kanej deleted the feat/alter-links-in-help-menu branch July 6, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants