Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update Claim Asset Flow #63

Closed
1 of 2 tasks
fcavazzoli opened this issue Sep 21, 2022 · 0 comments · Fixed by #62
Closed
1 of 2 tasks

feat: Update Claim Asset Flow #63

fcavazzoli opened this issue Sep 21, 2022 · 0 comments · Fixed by #62
Assignees

Comments

@fcavazzoli
Copy link
Contributor

fcavazzoli commented Sep 21, 2022

Use CAP to store ClaimableMessages

We are doing this to avoid having to call remove_claimable after the user withdraws the asset on ETH side.
Since CAP is scalable, remove_messages is no longer necessary.

  • remove_claimable candid method is going to be deleted.
  • get_claimable_messages candid method is going to be deleted because that query is being handled by CAP root.

Next

  • after perform some test. If everything works, delete the entire folder aws/ledger.
  • add a lambda to get starknet txHash with msg_key as param.

Frontend

  • Query CAP instead of the proxy
  • Use the lambda to fetch tx_status using starknet sdk. (this is not required but it would be an awesome improvement to user experience)
@fcavazzoli fcavazzoli self-assigned this Sep 21, 2022
@fcavazzoli fcavazzoli linked a pull request Sep 21, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant