Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[主線] [PTT] 實作熱門文章 #50

Closed
3 tasks done
PichuChen opened this issue Feb 11, 2021 · 6 comments
Closed
3 tasks done

[主線] [PTT] 實作熱門文章 #50

PichuChen opened this issue Feb 11, 2021 · 6 comments
Labels
help wanted Extra attention is needed

Comments

@PichuChen
Copy link
Member

PichuChen commented Feb 11, 2021

實作細節 / Details of Implement

根據目前架構,應該分成 delivery/http usecase repository 三個子 ISSUE 下去實作。

期程 / Schedule

  • 討論時間: 一週,到 2/18,可以和實作平行進行。
  • 實作時間: 一週,到 2/25
  • 確認時間: 一週,到 3/4

相關文件 / Documents

PTT 後端系統協定

@PichuChen PichuChen added the help wanted Extra attention is needed label Feb 11, 2021
@PichuChen PichuChen added this to To do in PTT 後端主要 via automation Feb 11, 2021
@PichuChen PichuChen moved this from To do to In progress in PTT 後端主要 Feb 12, 2021
@PichuChen PichuChen moved this from In progress to To do in PTT 後端主要 Feb 12, 2021
@linmeichu
Copy link
Contributor

我想寫寫看 delivery/http 的部分!

@PichuChen
Copy link
Member Author

我想寫寫看 delivery/http 的部分!

好,那你有辦法參考 #53 開一個子 ISSUE 然後 ref 到這個 ISSUE 嗎?

@wagaru
Copy link
Collaborator

wagaru commented Feb 19, 2021

想確認一下

所以可以假設 go-bbs 會實作 ReadPopularArticles() 的功能,裡面會回傳可能前 100 篇熱門文章的ArticleRecord
所以 usecase 只要回傳 repository 的資料, 無需做排序的處理?然後現階段應該還先不用使用 cache

是的話我可以幫忙 usecase 的部份~~

@PichuChen
Copy link
Member Author

想確認一下

所以可以假設 go-bbs 會實作 ReadPopularArticles() 的功能,裡面會回傳可能前 100 篇熱門文章的ArticleRecord
所以 usecase 只要回傳 repository 的資料, 無需做排序的處理?然後現階段應該還先不用使用 cache

對,理論上應該底層回傳的東西會有進行排序?

是的話我可以幫忙 usecase 的部份~~

OK 那你那邊可以開一個子 ISSUE 然後指到這個 ISSUE 嗎?

@wagaru
Copy link
Collaborator

wagaru commented Feb 20, 2021

有個小問題~

照這禮拜投影片的說明,這個母 issue 應該先開出 branch,子 issue 再發 PR 到這個 branch
但目前母 issue 應該是沒人認領開 branch?

@PichuChen
Copy link
Member Author

有個小問題~

照這禮拜投影片的說明,這個母 issue 應該先開出 branch,子 issue 再發 PR 到這個 branch
但目前母 issue 應該是沒人認領開 branch?

誒對

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
Development

No branches or pull requests

3 participants