Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI / CD 檔案建立 #6

Closed
PichuChen opened this issue Jan 22, 2021 · 9 comments · Fixed by #46
Closed

CI / CD 檔案建立 #6

PichuChen opened this issue Jan 22, 2021 · 9 comments · Fixed by #46
Assignees
Labels
help wanted Extra attention is needed

Comments

@PichuChen
Copy link
Member

突然發現這個專案好像還沒有設定 CI / CD ?

@mkfsn
Copy link
Contributor

mkfsn commented Jan 23, 2021

@PichuChen 有什麼選項嗎?目前我知道的有:

  1. CircleCI
  2. GithubCI
  3. TravisCI

如果 CI 確定的話我也想要導入 Linter:

  1. https://github.com/golangci/golangci-lint (feat: add golangci-lint and fix linting and typos #8)

@PichuChen
Copy link
Member Author

沒意外應該是 GitHub?

@PichuChen PichuChen added the help wanted Extra attention is needed label Jan 26, 2021
@Julian-Chu
Copy link
Contributor

assign給我吧(ps: slack裡面認領了)
我應該會先弄makefile command
然後CI直接call makefile

個人贊成 @mkfsn 引入linter的意見, 可以一併在這個issue處理

@Julian-Chu
Copy link
Contributor

Julian-Chu commented Jan 27, 2021

目前跑出來的CI流程結果可以在這看到 link

目前linter掃出一些問題所以紅燈, 等review流程完在修正

@PichuChen PichuChen added this to Review in progress in PTT 後端主要 Jan 28, 2021
@PichuChen
Copy link
Member Author

目前的 CI 好像沒辦法在 macOS 上面執行? 他會查不到 go bin

@Julian-Chu
Copy link
Contributor

Julian-Chu commented Feb 8, 2021

目前的 CI 好像沒辦法在 macOS 上面執行? 他會查不到 go bin

有error log嗎, 我看一下, 手邊沒有mac不能測
順便幫我確認一下 gobin是不是有設定了

@PichuChen
Copy link
Member Author

目前的 CI 好像沒辦法在 macOS 上面執行? 他會查不到 go bin

有error log嗎, 我看一下, 手邊沒有mac不能測
順便幫我確認一下 gobin是不是有設定了

預設應該是沒有設定

@PichuChen
Copy link
Member Author

@Julian-Chu 這邊是輸出的 log

$ ./make.bash lint
golangci/golangci-lint info checking GitHub for latest tag
golangci/golangci-lint info found version: 1.36.0 for v1.36.0/darwin/amd64
install: mkdir : No such file or directory
download golangci-lint into
golangci-lint checking...
./make.bash: line 49: /golangci-lint: No such file or directory

可能要考慮開發者沒有設定 gobin 時應該要怎麼給預設值的問題。
FYI

$ go env GOBIN

@Julian-Chu
Copy link
Contributor

#46 把GOBIN改成 GOPATH/bin ,GOPATH應該就不會有沒設定的問題了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
Development

Successfully merging a pull request may close this issue.

3 participants