Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release phsmethods 1.0.0 #110

Closed
17 of 24 tasks
Tina815 opened this issue Sep 19, 2023 · 2 comments
Closed
17 of 24 tasks

Release phsmethods 1.0.0 #110

Tina815 opened this issue Sep 19, 2023 · 2 comments
Assignees

Comments

@Tina815
Copy link
Contributor

Tina815 commented Sep 19, 2023

Prepare for release:

  • git pull
  • Check current CRAN check results
  • Check if any deprecation processes should be advanced, as described in Gradual deprecation
  • Polish NEWS
  • devtools::build_readme()
  • urlchecker::url_check()
  • devtools::check(remote = TRUE, manual = TRUE)
  • devtools::check_win_devel()
  • rhub::check_for_cran()
  • revdepcheck::revdep_check(num_workers = 4)
  • Update cran-comments.md
  • git push
  • Draft blog post

Submit to CRAN:

  • usethis::use_version('major')
  • devtools::submit_cran()
  • Approve email

Wait for CRAN...

  • Accepted 🎉
  • git push
  • usethis::use_github_release()
  • usethis::use_dev_version()
  • git push
  • Finish blog post
  • Tweet
  • Add link to blog post in pkgdown news menu
@Moohan Moohan self-assigned this Sep 28, 2023
@Moohan
Copy link
Member

Moohan commented Sep 28, 2023

Comments back from CRAN:

  • 1. References - I don't think this is applicable.
  • 2. Better / Longer Description
  • 3. Add return values for function documentation - Update the documentation #114

Thanks,

If there are references describing the methods in your package, please
add these in the description field of your DESCRIPTION file in the form
authors (year) doi:...
authors (year) arXiv:...
authors (year, ISBN:...)
or if those are not available: <[https:...]https:...>
with no space after 'doi:', 'arXiv:', 'https:' and angle brackets for
auto-linking. (If you want to add a title as well please put it in
quotes: "Title")

The Description field is intended to be a (one paragraph) description of
what the package does and why it may be useful. Please add more details
about the package functionality and implemented methods in your
Description text.

Please add \value to .Rd files regarding exported methods and explain
the functions results in the documentation. Please write about the
structure of the output (class) and also what the output means. (If a
function does not return a value, please document that too, e.g.
\value{No return value, called for side effects} or similar)
Missing Rd-tags:
age_calculate.Rd: \value
chi_pad.Rd: \value
extract_fin_year.Rd: \value
qtr.Rd: \value
rename.Rd: \value

Please fix and resubmit.

Best,
Benjamin Altmann

@Moohan Moohan assigned Tina815 and unassigned Moohan Nov 24, 2023
@Moohan
Copy link
Member

Moohan commented Nov 24, 2023

@Tina815 Is there anything left to do on this, other than update the README, and any comms etc.

@Moohan Moohan closed this as completed Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants