Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement check_year #48

Merged
merged 8 commits into from
Mar 10, 2023
Merged

Implement check_year #48

merged 8 commits into from
Mar 10, 2023

Conversation

Moohan
Copy link
Member

@Moohan Moohan commented Mar 7, 2023

This code was mostly written but for some reason not implemented. I've added it in to the relevant places and improved the error messages.

This fixes #46 (and #47)

@Moohan Moohan linked an issue Mar 7, 2023 that may be closed by this pull request
Do a better job of checking the supplied year is valid #46
Open
@Jennit07 Jennit07 self-requested a review March 10, 2023 12:07
Jennit07
Jennit07 approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@Jennit07 Jennit07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this through and looks good! Happy to merge

@Jennit07 Jennit07 merged commit 7b01037 into development Mar 10, 2023
@Jennit07 Jennit07 deleted the check_year branch March 10, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jennit07 Jennit07 Jennit07 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do a better job of checking the supplied year is valid
2 participants
@Moohan @Jennit07