Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Added alternative signposting to package vignettets in README. Comple…
…ted cran comments.
- Loading branch information
1 parent
83398cc
commit a248de0
Showing
3 changed files
with
23 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,29 @@ | ||
## Submission of package version 1.3.1 | ||
Five functions within the package have been amended to ensure continued compatability with dplyr v1.0.0 due for release 1st May 2020. | ||
|
||
Additionally, the phe_life_expectancy function has been amended to show more relevant population and death counts in the output. | ||
Additionally, the phe_life_expectancy function has been amended (bug fix) to show more relevant population and death counts in the output. | ||
|
||
## R CMD check results | ||
There were no ERRORs, WARNINGS or NOTES on local Windows 10 install using R 3.6.3 and RStudio 1.2.5019 | ||
|
||
## Test Environments | ||
* local windows 10 installs: R3.6.3 - OK | ||
local windows 10 installs: R3.6.3 - OK | ||
|
||
* Travis check on Linux (2020-04-11) - passed | ||
Travis check on Linux (2020-04-11) - OK | ||
|
||
* devtools::check_win gave no ERRORS, WARNINGS or NOTES on the following versions: R version 3.5.3 (2019-03-11), R version 3.6.3 (2020-02-29) and R Under development (unstable) (2020-01-28 r77738). | ||
devtools::check_win gave no ERRORS, WARNINGS or NOTES on the following versions: | ||
* R version 4.0.0 alpha (2020-03-26 r78078) | ||
* R version 3.6.3 (2020-02-29) | ||
* R version 3.5.3 (2019-03-11) | ||
|
||
* devtools::check_rhub has been run on the following platforms: Fedora Linux, R-devel, clang, gfortran; Windows Server 2008 R2 SP1, R-devel, 32/64 bit; Ubuntu Linux 16.04 LTS, R-release, GCC. These build checks produced a couple of NOTES about possible mispellings, possible invalid DOIs which are all valid and not critical to the functioning of the package. | ||
* devtools::check_rhub has been run on the following platforms. These build checks produced a couple of NOTES about possible mispellings, possible invalid DOIs which are all valid and not critical to the functioning of the package: | ||
* Fedora Linux, R-devel, clang, gfortran | ||
* Windows Server 2008 R2 SP1, R-devel, 32/64 bit | ||
* Ubuntu Linux 16.04 LTS, R-release, GCC | ||
|
||
|
||
## CRAN Checks for current package release version v1.3.0 | ||
There is currently a WARNING against r-patched-osx-x86_64 which relates to an issue loading the package vignette. I am unable to resolve this without access to this OS. The vignettes seem to work Ok elsewhere and are not essential to the package functionality. I have added a comment to the README file offering alternative signposting to package vignettes on CRAN package webpage. | ||
|
||
## Downstream dependencies | ||
There are no known downstream dependencies on CRAN |