Removed curl from DESCRIPTION again, and removed dependency from test…

…-examples
ukhsa-collaboration · Mar 5, 2020 · 9a9258b · 9a9258b
1 parent 514058c
commit 9a9258b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 10 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -24,7 +24,6 @@ Imports:
     tidyr (>= 1.0.0),
     utils
 Suggests:
-    curl,
     gdtools,
     knitr,
     rmarkdown,

diff --git a/tests/testthat/test-examples.R b/tests/testthat/test-examples.R
@@ -113,9 +113,11 @@ test_that("box plot example draws correctly", {
         )
 })
 
-if(curl::has_internet()) {
+context("map-example")
 
-        context("map-example")
+
+test_that("map example draws correctly", {
+        skip_if_offline()
         ons_api <- "https://opendata.arcgis.com/datasets/687f346f5023410ba86615655ff33ca9_4.geojson"
 
         p <- fingertipscharts::map(mapdata,
@@ -125,13 +127,10 @@ if(curl::has_internet()) {
                                    title = "Map example",
                                    subtitle = "An indicator for Upper Tier Local Authorities England",
                                    copyright_year = 2019)
-
-        test_that("map example draws correctly", {
-                vdiffr::expect_doppelganger("map example",
-                                            p
-                )
-        })
-}
+        vdiffr::expect_doppelganger("map example",
+                                    p
+        )
+})
 
 context("area-profiles-example")
 df <- create_test_data() %>%