Rewrite null values in SHP export to prevent them from being dropped #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurizi
force-pushed
the
feature/mvm/fix-shp-export
branch
from
89eaaa9
to
2629474
Compare
kshepard
suggested changes
Jan 15, 2021
There was a problem hiding this comment.
It looks like the field names have disappeared (they're just showing up as numbers). And also, I'm seeing the compactness column (field #6), but it's seemingly empty for districts that should have a compactness score. Like my district selected in this screenshot, which has a 36% compactness score on the frontend.
maurizi
force-pushed
the
feature/mvm/fix-shp-export
branch
3 times, most recently
from
1e04ca5
to
67811cc
Compare
kshepard
suggested changes
Jan 19, 2021
The Shapefile format doesn't seem to like mixed data types, and so our compactness column was being dropped when either the unassigned district had a NULL value for compactness or when at least one district was non-contiguous. To accomodate this, I've introduced a generated "contiguity" column of string type, and switched from using NULL to using 0 in cases of no data.
maurizi
force-pushed
the
feature/mvm/fix-shp-export
branch
from
67811cc
to
1e3e091
Compare
kshepard
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue of the compactness field being dropped, which seems to have happened whenever the first district had a null value.This manifested in compactness scores being dropped, but I think would be an issue for any nullable field.Edit:
The initial approach didn't work out well, and was reworked in 1e3e091 to make the
compactnessfield numeric-only and add a newcontiguityfield in the export.Checklist
CHANGELOG.mdand grouped with similar changes, if possibleTesting Instructions
developthe Shapefile export should not have acompactnesscolumn - on this branch it shouldCloses #554