-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return to using stdlib's URL escaping #14
Comments
Yeah, it is now fixed in Go1.5 but it's unlikely people will all upgrade that fast, so I'd be tempted to leave it in for a while, at least until Go1.6, maybe even another release after that. I think a conditional build tag could be used, I may take a look at that when I have a moment, so I'll leave that open. Thanks for the heads up! |
I tried making this change locally (returning Should this be expected, and the tests just need to be fixed? I'm just unsure which package ( Here's the output of a portion of the tests:
Edit: After researching more into it, it appears that this commit golang/go@874a605 changed how the One fix that resolves most of the test errors is just setting While the standard So, what do you think would be best? AFAIK, most browsers and other clients will still allow the unreserved characters labeled in RFC 2396, which the current |
Yeah, I did give it a shot a while ago and ran into those issues but I didn't dig deeper at that moment, sorry I should've documented it a bit here. Thanks for looking into it, I think that regardless of what browsers support, the change should try to maintain behaviour with what purell does now. If it's down to only those few characters, maybe it could be done in purell itself, modifying the *url.URL struct directly, so we could get rid of the external dep. |
Would like to see the latest comment implemented. |
Me too! I'd be happy to accept a PR that implements this and makes all tests pass. |
Issue 5684 is now closed, so it might be time to revert PR 9.
The text was updated successfully, but these errors were encountered: