This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Removing docker v1 tests from repo #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the following pulp_docker PR, docker v1 is now depreciated and no longer supported: * pulp/pulp_docker#348 Failures were seen in docker v1 in CI. Decided to go ahead and remove the v1 tests in the deprecation period. Closes #4941
nixocio
approved these changes
Jun 10, 2019
rochacbruno
approved these changes
Jun 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Per the following pulp_docker PR, docker v1 is now depreciated and no longer supported:
Failures were seen in docker v1 in CI.
Solution
Decided to go ahead and remove the v1 tests in the deprecation period.
References
Additional Note
There was a NOFIX issue in
_do_test_invalid_upstream_namefor DOCKER V2.Went ahead and removed this case as the test is always skipped and the issue is already determined as NOFIX
Closes #4941