Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulp should support more conservative dependency solving #1090

Closed
6 tasks
dparalen opened this issue Jun 27, 2018 · 7 comments
Closed
6 tasks

Pulp should support more conservative dependency solving #1090

dparalen opened this issue Jun 27, 2018 · 7 comments

Comments

@dparalen
Copy link

dparalen commented Jun 27, 2018

Description

Copying rpm units between repositories should only associate units that the target repository misses to satisfy any (versioned) dependencies. To give a real-life workflow example:

  • create a fedora27 repository and populate it with the Fedora 27 content
  • create a fedora28 repository and populate it with the Fedora 28 content
  • create an empty repository foo
  • recursively copy the glibc rpm from the fedora27 repository to the foo repository
  • recursively copy the bash rpm from the fedora28 repository to the foo repository
  • check that just the bash rpm was copied

Before pulp/pulp_rpm#1122, all the bash dependencies would have been pulled in because Pulp would have filtered the units based on their DB IDs rather than what they actually provide.

Notes

🐞 https://pulp.plan.io/issues/2478

Mind the content URLs above use a Brno Fedora content mirror

@RCMariko
Copy link
Member

When testing this, please note original redmine issue on what repo dependencies were copied previously and will no longer would be copied - that detail is missing from the example above. Unit versions were mentioned in the original issue.

@dparalen
Copy link
Author

@RCMariko thanks for checking!
Yeah this test would have been insufficient as the current Pulp implementation filters solver-identified units already present in the target repository: mea culpa, I haven't checked that before!

Updating the steps...

@Ichimonji10
Copy link
Contributor

This is a Pulp 2 test case, correct?

@RCMariko
Copy link
Member

Yes. 2.17.0 candidate.

@RCMariko
Copy link
Member

@dparalen - I like those clarification - these details make more sense to me. Hopefully others agree/understand better. Thank you.

@rochacbruno
Copy link
Member

@kersommoura @ragabala is this issue addressed by that CopyUnits test cases?

nixocio pushed a commit to nixocio/Pulp-2-Tests that referenced this issue Sep 6, 2018
Update the docstring of `CopyRecursiveUnitsTestCase` to include another issue
related to this test case.

See: pulp/pulp-smash#1090
nixocio pushed a commit to nixocio/Pulp-2-Tests that referenced this issue Sep 6, 2018
Update the docstring of `CopyRecursiveUnitsTestCase` to include another issue
related to this test case.

See: pulp/pulp-smash#1090
rochacbruno pushed a commit to pulp/Pulp-2-Tests that referenced this issue Sep 6, 2018
Update the docstring of `CopyRecursiveUnitsTestCase` to include another issue
related to this test case.

See: pulp/pulp-smash#1090
@nixocio
Copy link

nixocio commented Sep 6, 2018

There is already a test in place exploring this feature. CopyRecursiveUnitsTestCase

@nixocio nixocio closed this as completed Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants