Introduce BASE_CONTENT_GUARD_PATH #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Or maybe it should be s/CONTENT_GUARDS_BASE_PATH/CONTENT_GUARDS_PATH/ just lmk |
rochacbruno
reviewed
Mar 29, 2019
pulp_smash/pulp3/constants.py
Outdated
| @@ -16,7 +16,7 @@ | |||
|
|
|||
| BASE_PUBLISHER_PATH = urljoin(BASE_PATH, "publishers/") | |||
|
|
|||
| CONTENT_GUARDS_PATH = urljoin(BASE_PATH, "contentguards/certguard/certguard/") | |||
| CONTENT_GUARDS_BASE_PATH = urljoin(BASE_PATH, "contentguards/") | |||
There was a problem hiding this comment.
Suggested change
| CONTENT_GUARDS_BASE_PATH = urljoin(BASE_PATH, "contentguards/") | |
| BASE_CONTENT_GUARDS_PATH = urljoin(BASE_PATH, "contentguards/") |
There was a problem hiding this comment.
+1 to this, this is more consistent with what is here.
There is an existing constant called CONTENT_GUARD_PATH which includes plugin-specific portions to its URL. This changes the name to indicate it's only a BASE path and includes only the URL portions that are specified by core. The corresponding viewset comes from here: https://github.com/pulp/pulpcore/blob/7fdc5626559051e540509f7b699c28684e1043a9/pulpcore/app/viewsets/publication.py#L49
bmbouter
force-pushed
the
update-content-guard-base-path
branch
from
dd7f9cf
to
4c29e37
Compare
bmbouter
changed the title
rochacbruno
approved these changes
Mar 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an existing constant called CONTENT_GUARD_PATH which includes
plugin-specific portions to its URL. This changes the name to indicate
it's only a BASE path and includes only the URL portions that are
specified by core.
The corresponding viewset comes from here: https://github.com/pulp/pulpcore/blob/7fdc5626559051e540509f7b699c28684e1043a9/pulpcore/app/viewsets/publication.py#L49