Add smart_handler as the default for api.Client

[rochacbruno]

This handler can decide which handler to use based
on content response.

[nixocio]

@rochacbruno I do like this idea. To have a generic response_handler for Pulp 3 that the user does not need to know in advance what kind of status code, or a pagination will be part of the response. We need to test this to assure that we are not missing any edge case. What are about we call it generic_handler or general_handler?

[rochacbruno]

@kersommoura

I suggest something like

• base_handler
• default_handler
• dispatch_handler (ugly name, but very meaningful)

[nixocio]

@rochacbruno naming anything it is so hard. @bherrin3 can decide.

[nixocio]

In my mind the name has to show the intent...and the intent it is to be a general reponse_handler for Pulp 3. One that the user will pick in the cases that user does not know what response will get back from Pulp 3. But I am fine with any choice.

[rochacbruno]

@kersommoura if we want to show intent, then smart_handler is ok!

Like other tech examples:

• Smart Phone
• Smart Templates

We want to express the idea that

This handler can make its own choice based on context

I vote for smart_ or dispatch_

[rochacbruno]

Or auto_handler - automatic_handler

[bherrin3]

hmm.. I think you may already have the right name with smart_handler. That has intelligent to decide which is the appropriate handler given the case. I don't think it infers anything other than it uses logic to decide the appropriate handler.

Else, a method name that names the action is doing. I am not sure why this is post-pended with _handler. However, of the names presented, smart_handler is the best I have seen.

Using base_ or default_ assumes there is a base class (subset) that is common to all handlers you are using, which is not the case here. The appropriate handler is being chosen. Maybe the function name shouldn't have handler in it since it is chosing and returning a handler and not actually a handler?

I don't have a dog in this race. I would just choose something and comment what it does. :)

[rochacbruno]

Here's a good name:
client = api.Client(reponse_handler=api.use_this_if_you_dont_know_how_to_choose_a_handler).get(...)

😄

Why so serious?

lets call it ninja_handler, super_handler, handler_with_lasers or use some buzzword like awesome_handler

[rochacbruno]

Lets stick with smart_handler ? So we can put some test cases and merge

[nixocio]

@rochacbruno, I am reviewing this one. Good job. Nice unittests.

I updated the pagination test to use the smart_handler, and test failed. I am evaluating this one right now.

[nixocio]

@rochacbruno, it was an error on my side. I tested a few tests for Pulp 3 using the smart_handler, and all passed.

[nixocio]

Just suggestions. Not blockers.