Changing download_policies #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmacdo
reviewed
Jul 2, 2019
|
|
||
| JWT_PATH = urljoin(BASE_PATH, "jwt/") |
There was a problem hiding this comment.
We kept this one around since JWT could be added back based on the discussions at the time.
There was a problem hiding this comment.
Since then though we removed the JWT entirely so I think we should remove this too.
nixocio
reviewed
Jul 2, 2019
There was a problem hiding this comment.
A few tests will be required to be updated with those changes.
Just a few examples, see: test content delivery
download content
pulp_smash/pulp3/constants.py
Outdated
| @@ -22,13 +22,9 @@ | |||
|
|
|||
| DISTRIBUTION_PATH = urljoin(BASE_PATH, "distributions/") | |||
|
|
|||
| DOWNLOAD_POLICIES = ("immediate", "on_demand", "streamed") | |||
| DOWNLOAD_POLICIES = ("immediate", ) | |||
There was a problem hiding this comment.
This name can be misleading. Since it is plural. I would suggest:
Suggested change
| DOWNLOAD_POLICIES = ("immediate", ) | |
| IMMEDIATE_DOWNLOAD_POLICY = ("immediate", ) |
There was a problem hiding this comment.
I pushed this fix, but what about just making it
IMMEDIATE_POLICY = "immediate" since it's single now.
bmbouter
force-pushed
the
restrict-remotes
branch
from
737d20f
to
4432147
Compare
bmbouter
pushed a commit
to bmbouter/pulpcore
that referenced
this pull request
Jul 2, 2019
The "lazy" variables are renamed to be "on-demand" to match recent changes in pulp-smash. Required PR: pulp/pulp-smash#1210 [noissue]
This was referenced Jul 2, 2019
bmbouter
pushed a commit
to bmbouter/pulpcore
that referenced
this pull request
Jul 2, 2019
The "lazy" variables are renamed to be "on-demand" to match recent changes in pulp-smash. Required PR: pulp/pulp-smash#1210 Required PR: pulp/pulp_file#255 [noissue]
bmbouter
force-pushed
the
restrict-remotes
branch
from
4432147
to
3c5d739
Compare
|
I pushed PRs to pulpcore and pulp_file with fixes: |
nixocio
pushed a commit
to nixocio/pulp_rpm
that referenced
this pull request
Jul 2, 2019
The names were updated to replace 'lazy' with 'on demand' and also reflect the recently changed validation in pulpcore. Required PR: pulp/pulpcore#199 Required PR: pulp/pulp-smash#1210 [noissue]
bmbouter
force-pushed
the
restrict-remotes
branch
3 times, most recently
from
5c0f301
to
e1db5da
Compare
nixocio
reviewed
Jul 3, 2019
pulp_smash/pulp3/constants.py
Outdated
| @@ -2,9 +2,9 @@ | |||
| """Constants for Pulp 3 tests.""" | |||
| from urllib.parse import urljoin | |||
|
|
|||
| from pulp_smash.api import ( # noqa: F401 | |||
| from pulp_smash.api import ( | |||
There was a problem hiding this comment.
Suggested change
| from pulp_smash.api import ( | |
| from pulp_smash.api import ( # noqa: F401 | |
| _P3_TASK_END_STATES as P3_TASK_END_STATES, | |
| ) |
With pulp/pulpcore@59f3450 the download policy by default only includes 'immediate'. Required PR: pulp/pulpcore#199 Required PR: pulp/pulp_file#255 [noissue]
bmbouter
force-pushed
the
restrict-remotes
branch
from
e1db5da
to
2347e0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With pulp/pulpcore@59f3450
the download policy by default only includes 'immediate'.
[noissue]