Problem: can't run CLI related tests on kubernetes #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkliban
force-pushed
the
kubectl
branch
3 times, most recently
from
6ef5782
to
ddf045a
Compare
rochacbruno
approved these changes
Aug 12, 2019
There was a problem hiding this comment.
LGTM 🚀
Not a blocker but my only comment is that the docstring can be updated to mention the new feature, doing it will generate the documentation with that comment on https://pulp-smash.readthedocs.io/en/latest/api/pulp_smash.cli.html
mikedep333
reviewed
Aug 12, 2019
mikedep333
requested changes
Aug 12, 2019
pulp_smash/cli.py
Outdated
| @@ -276,6 +282,9 @@ def run(self, args, sudo=False, **kwargs): | |||
| kwargs.setdefault("retcode") | |||
| logger.debug("Running %s cmd (sudo:%s) - %s", args, sudo, kwargs) | |||
|
|
|||
| if self._podname: | |||
| args = ("kubectl", "exec", self._podname) + tuple(args) | |||
There was a problem hiding this comment.
We need -- (dash dash) at the end also.
So that we can run commands with arguments.
pulp_smash/cli.py
Outdated
| @@ -276,6 +282,9 @@ def run(self, args, sudo=False, **kwargs): | |||
| kwargs.setdefault("retcode") | |||
| logger.debug("Running %s cmd (sudo:%s) - %s", args, sudo, kwargs) | |||
|
|
|||
| if self._podname: | |||
| args = ("kubectl", "exec", self._podname) + tuple(args) + ("--",) | |||
There was a problem hiding this comment.
The -- needs to become before the command you actually run.
mikedep333
added a commit
to mikedep333/pulpcore
that referenced
this pull request
Aug 12, 2019
[noissue] Required PR: pulp/pulp-smash#1215
Solution: add ability to specify 'kubectl' as shell transport
mikedep333
approved these changes
Aug 12, 2019
mikedep333
added a commit
to mikedep333/pulpcore
that referenced
this pull request
Aug 20, 2019
[noissue] Required PR: pulp/pulp-smash#1215
mikedep333
added a commit
to mikedep333/pulpcore
that referenced
this pull request
Aug 21, 2019
[noissue] Required PR: pulp/pulp-smash#1215
mikedep333
added a commit
to mikedep333/pulpcore
that referenced
this pull request
Aug 26, 2019
[noissue] Required PR: pulp/pulp-smash#1215
mikedep333
added a commit
to mikedep333/pulpcore
that referenced
this pull request
Aug 26, 2019
[noissue] Required PR: pulp/pulp-smash#1215
mikedep333
added a commit
to mikedep333/pulpcore
that referenced
this pull request
Aug 28, 2019
[noissue] Required PR: pulp/pulp-smash#1215
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: add ability to specify 'kubectl' as shell transport