[WIP] kubectl: Always use sudo in front of it rather than conditionally #1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k3s's embedded kubectl requires this. And that's what we use on Travis CI.
mikedep333
added a commit
to mikedep333/pulpcore
that referenced
this pull request
Aug 20, 2019
[noissue] Required PR: pulp/pulp-smash#1217
mikedep333
added a commit
to mikedep333/pulpcore
that referenced
this pull request
Aug 20, 2019
[noissue] Required PR: pulp/pulp-smash#1217
mikedep333
added a commit
to mikedep333/pulpcore
that referenced
this pull request
Aug 21, 2019
[noissue] Required PR: pulp/pulp-smash#1217
mikedep333
added a commit
to mikedep333/pulpcore
that referenced
this pull request
Aug 21, 2019
[noissue] Required PR: pulp/pulp-smash#1217
mikedep333
added a commit
to mikedep333/pulpcore
that referenced
this pull request
Aug 21, 2019
[noissue] Required PR: pulp/pulp-smash#1217
|
@mikedep333, do we have any travis PR/branch with tests running using this change? |
|
I just saw the pulpcore PRs. |
mikedep333
added a commit
to mikedep333/pulpcore
that referenced
this pull request
Aug 26, 2019
[noissue] Required PR: pulp/pulp-smash#1217
mikedep333
added a commit
to mikedep333/pulpcore
that referenced
this pull request
Aug 26, 2019
[noissue] Required PR: pulp/pulp-smash#1217
|
@dkliban @mikedep333 do we still need this one? The #1218 is already merged. |
|
#1218 was merged instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
k3s's embedded kubectl requires this. And that's what we use on Travis CI.