Add assertions testing the Docker v2 publish results. #139
Conversation
bowlofeggs
force-pushed
the
docker_publish
branch
from
0d703c4
to
70b5f02
Compare
|
These tests are for https://pulp.plan.io/issues/1051. |
| self.assertTrue( | ||
| all([l.keys() == ['blobSum'] for l in manifest['fsLayers']])) | ||
| self.assertTrue( | ||
| all([isinstance(l['blobSum'], (str, unicode)) |
There was a problem hiding this comment.
This fails on Python 3.
>>> isinstance('foo', (str, unicode))
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
NameError: name 'unicode' is not defined
How about this?
isinstance('foo', (type(u''), type(b'')))
TrueThere was a problem hiding this comment.
Yeah I noticed that on Friday but it was 5 PM so I figured I'd save it for Monday. The type solution seems good. I was considering using the six library to fix this. Do you prefer your technique? It does avoid adding a dependency so that's good.
There was a problem hiding this comment.
Six would work well, and I certainly respect it as a lib. But it does seem excessive to add six as a dependency when there's so few use cases for it. That's the same reason I haven't added a random data generation lib - uuid4() and a few random.randint() calls have worked well enough.
Yeah I noticed that on Friday but it was 5 PM so I figured I'd save it for Monday.
👍
There was a problem hiding this comment.
@Ichimonji10 I have made the change you suggested, and the tests now pass.
This commit adds several assertions to an existing sync/publish CLI test case that ensure that the result of the pulp_docker v2 publish has the expected data that the Docker client will need.
bowlofeggs
force-pushed
the
docker_publish
branch
from
70b5f02
to
25d02ab
Compare
This commit adds several assertions to an existing sync/publish
CLI test case that ensure that the result of the pulp_docker v2
publish has the expected data that the Docker client will need.