WIP: Skip known failing tests #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I could use some help identifying the issues in our bug tracker that correspond to the skipped tests in this PR. Search for the keyword "FIXME" to find them. |
|
@pulp Whenever you have a chance. |
|
@asmacdo I saw that you commented out some failing tests in some other code you're working on. Consider reviewing this PR and/or rebasing your branch onto this one. |
Skip failing tests. This is a temporary solution until #29 and #30 are fixed. The idea is that it's better to highlight real regressions than drown the user in known issues. In the immediate future, developers who'd like to know if they've fixed an issue can remove relevant `skipTest()` lines from their local copies of the test suite. Not optimal, but workable. Also, update a test that made an assertion about an undesirable behaviour. Method `ReadUpdateDeleteTestCase.test_deleted_user` in module `pulp_smash.tests.platform.api_v2.test_user` now correctly passes a JSON body in a PUT request for a user. Tested against Pulp 2.6 and 2.7: $ python -m unittest2 discover pulp_smash.tests ....s...sssssss.s.....ssss........................................s........ ---------------------------------------------------------------------- Ran 72 tests in 30.678s OK (skipped=14)
|
I'm going to take some time to reconsider my approach here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip failing tests. This is a temporary solution until #29 and #30 are fixed.
The idea is that it's better to highlight real regressions than drown the user
in known issues. In the immediate future, developers who'd like to know if
they've fixed an issue can remove relevant
skipTest()lines from their localcopies of the test suite. Not optimal, but workable.
Tested against Pulp 2.6: