Support ./setup.py test
#42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #2: > The canonical way to run Pulp Smash's unit tests is via the `make test` command. > This works, but its implementation is entirely ad-hoc. We should consider > supporting the `test` command provided by setuptools. According to [the > documentation](http://pythonhosted.org/setuptools/setuptools.html#test): > > > The test command runs a project’s unit tests without actually deploying it, by > > temporarily putting the project’s source on sys.path, after first running > > build_ext -i and egg_info to ensure that any C extensions and project metadata > > are up-to-date. Remove `unittest2` from `requirements-dev.txt`. It is already listed in `setup.py`, and the duplication was a bug. Move `mock` from `requirements-dev.txt` to `setup.py`. This change means that Pulp Smash has a new base dependency, but this is the only change necessary to support `./setup.py test`, so the change seems worthwhile. Make Travis test this new command as part of the testing procedure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #2:
Remove
unittest2fromrequirements-dev.txt. It is already listed insetup.py, and the duplication was a bug.Move
mockfromrequirements-dev.txttosetup.py. This change means thatPulp Smash has a new base dependency, but this is the only change necessary to
support
./setup.py test, so the change seems worthwhile.Make Travis test this new command as part of the testing procedure.