Use urljoin in pulp_smash.utils
#59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #58: > Many places in the tests combine URLs and paths with simple string addition. > This has the potential to produce incorrect results. […] Pulp should produce > paths that behave correctly with urljoin, and we've had problems in the past > with developers making "relative paths" that have a leading slash. Using urljoin instead of plain string concatenation lets Pulp Smash test the paths returned by Pulp. If Pulp returns a relative path with a leading slash, plain string concatenation will produce a path containing a (typically harmless but incorrect) `//`, but urljoin will produce a just-plain-wrong URL. Test results both before and after change: ============ ============================= Pulp Version Test Suite Results ============ ============================= 2.7 OK (skipped=13) dev (2.8) FAILED (errors=2, skipped=13) ============ ============================= Command used: PULP_SMASH_CONFIG_FILE=$PS_CONFIG \ python -m unittest2 discover pulp_smash.tests
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #58:
Using urljoin instead of plain string concatenation lets Pulp Smash test the
paths returned by Pulp. If Pulp returns a relative path with a leading slash,
plain string concatenation will produce a path containing a (typically harmless
but incorrect)
//, but urljoin will produce a just-plain-wrong URL.Test results both before and after change:
Command used: