Add test for Pulp 2788 #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ichimonji10, as we talked, adding a negative test case for |
|
Updated and re-tested. |
nixocio
approved these changes
Dec 18, 2017
|
@Ichimonji10, with this new change, the test will behave as expected. |
Deduplicate docstring information. This makes it possible to add an additional test case to the module without breaking any semantics. Drop an unused constant. It's unnecessary. Sync unsigned RPMs, instead of signed RPMs. This means less data is pushed around and processed, which makes the test slightly quicker.
Add `RemoveOldRepodataTestCase`, which verifies that old repodata is removed when it should be. See: https://pulp.plan.io/issues/2788 Fix: #681
|
Re-tested against beta 3. The test now passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit just does some refactoring. The second adds a test case for Pulp 2788.