Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whole Words option should support the "$" symbol for PHP files #73

Closed
ShimShamSam opened this issue May 22, 2015 · 4 comments
Closed

Whole Words option should support the "$" symbol for PHP files #73

ShimShamSam opened this issue May 22, 2015 · 4 comments

Comments

@ShimShamSam
Copy link

A recent change in Atom has made double-clicking a word select it including the dollar sign. This makes the Whole Words option ignore the word and fail to highlight matches.

@richrace
Copy link
Member

Can you check what your Non Word Characters are in settings please?

@richrace
Copy link
Member

So you'd expect all the test below to be highlighted (and not the last one):

$test = "test"
// Some test file
// Don't highlight thistest

And when the $test is highlight you expect the box to be around all of it like: $test?

@ShimShamSam
Copy link
Author

@richrace You are correct. Where can I find Non-Word Characters setting? I do not see an option for it.

@ghost
Copy link

ghost commented May 26, 2015

I came here to report the same issue. The change to include the dollar sign in the selection in itself doesn't seem entirely illogical (the variable name includes the dollar, after all), but it made using this extension to quickly see occurrences of a variable very impractical by requiring that you only select the portion after the dollar sign.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants