-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create moonbeam-types-bundle npm package and added it to tests #150
Conversation
Oh yeah and also what license do we want? |
which of the CI actions is running the tests? |
ha ok the build |
Probably GPL3. That's what the repo's LICENCE file says,a nd how all the Cargo.toml files are annotated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me so far.
Co-authored-by: Joshy Orndorff <JoshOrndorff@users.noreply.github.com>
ok this PR needs a little bit more work before being merged. btw @JoshOrndorff how do I get the value related to ExitReason with the api? |
I don't understand what you mean. |
I'm trying to setup a test that would fail if those types weren't implemented. So I'm trying to understand what feature this type is associated with, i.e. what api function I need to test. The api is actually quite complex to understand... |
What does it do?
moonbeam-types-bundle
to be used like this when using the api:What important points reviewers should know?
npm publish is not adde to CI yet
What value does it bring to the blockchain users?
This will make sure the same types are used both in apps and our tests, preventing the apps from breaking when using moonbeam in the future
Checklist
Do we have a tutorial on using the polkadot api with Moonbeam? Otherwise no