Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create moonbeam-types-bundle npm package and added it to tests #150

Merged
merged 16 commits into from
Jan 4, 2021

Conversation

joelamouche
Copy link
Contributor

What does it do?

  • Create npm package moonbeam-types-bundle to be used like this when using the api:
const polkadotApi = await ApiPromise.create({
   provider: wsProvider,
   typesBundle
 });
  • use it in our tests
  • this package will be used in the polkadot/apps

What important points reviewers should know?

npm publish is not adde to CI yet

What value does it bring to the blockchain users?

This will make sure the same types are used both in apps and our tests, preventing the apps from breaking when using moonbeam in the future

Checklist

  • Does it require a purge of the network?
  • You bumped the runtime version if there are breaking changes in the runtime ?
  • Does it require changes in documentation/tutorials ?
    Do we have a tutorial on using the polkadot api with Moonbeam? Otherwise no

@joelamouche joelamouche added A0-pleasereview Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low Does not elevate a release containing this beyond "low priority". labels Dec 29, 2020
@joelamouche
Copy link
Contributor Author

Oh yeah and also what license do we want?

@joelamouche
Copy link
Contributor Author

which of the CI actions is running the tests?

@joelamouche
Copy link
Contributor Author

ha ok the build

@JoshOrndorff
Copy link
Contributor

Probably GPL3. That's what the repo's LICENCE file says,a nd how all the Cargo.toml files are annotated.

Copy link
Contributor

@JoshOrndorff JoshOrndorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me so far.

moonbeam-types-bundle/.gitignore Show resolved Hide resolved
moonbeam-types-bundle/index.ts Outdated Show resolved Hide resolved
moonbeam-types-bundle/index.ts Outdated Show resolved Hide resolved
moonbeam-types-bundle/package.json Outdated Show resolved Hide resolved
moonbeam-types-bundle/package.json Show resolved Hide resolved
moonbeam-types-bundle/package.json Outdated Show resolved Hide resolved
tests/tests/util/testWithMoonbeam.ts Show resolved Hide resolved
joelamouche and others added 3 commits December 30, 2020 13:10
Co-authored-by: Joshy Orndorff <JoshOrndorff@users.noreply.github.com>
@joelamouche
Copy link
Contributor Author

ok this PR needs a little bit more work before being merged. btw @JoshOrndorff how do I get the value related to ExitReason with the api?

@JoshOrndorff
Copy link
Contributor

how do I get the value related to ExitReason with the api?

I don't understand what you mean.

@joelamouche
Copy link
Contributor Author

I don't understand what you mean.

@JoshOrndorff

I'm trying to setup a test that would fail if those types weren't implemented. So I'm trying to understand what feature this type is associated with, i.e. what api function I need to test. The api is actually quite complex to understand...

@joelamouche joelamouche merged commit ac7774e into master Jan 4, 2021
@joelamouche joelamouche deleted the antoine-types-bundle-module branch January 4, 2021 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-pleasereview Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low Does not elevate a release containing this beyond "low priority".
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants