[MOON-1745] re-add status Leaving as deprecated #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbaztec
added
B7-runtimenoteworthy
crystalin
approved these changes
Jul 21, 2022
notlesh
approved these changes
Jul 21, 2022
crystalin
pushed a commit
that referenced
this pull request
Jul 21, 2022
* merge master * fix tests * fix toJSON
This was referenced Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Re-adds
DelegationStatus::Leavingas a deprecated variant. This fixes decode problems for any delegators containing the old variant in theirstatusfield under theDelegatorStatestorage.schedule_leave_delegators,cancel_leave_delegators&execute_leave_delegatorswill now infallibly update theDelegatorStatus::LeavingtoDelegatorStatus::Activeif encountered.What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?