Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenGov for Moonbeam #2285

Merged
merged 15 commits into from
May 24, 2023
Merged

Add OpenGov for Moonbeam #2285

merged 15 commits into from
May 24, 2023

Conversation

fgamundi
Copy link
Contributor

@fgamundi fgamundi commented May 8, 2023

What does it do?

Enables OpenGov and its associated precompiles in the Moonbeam runtime, following the Foundation's proposal.
Added GeneralAdmin as Origin for some extrinsics (following #2044)

@fgamundi fgamundi added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited breaking Needs to be mentioned in breaking changes labels May 8, 2023
@fgamundi fgamundi marked this pull request as ready for review May 8, 2023 15:39
@github-actions
Copy link
Contributor

github-actions bot commented May 12, 2023

Coverage generated "Mon May 22 16:01:15 UTC 2023":
https://s3.amazonaws.com/moonbeam-coverage/pulls/2285/html/index.html

Master coverage: 72.42%
Pull coverage: 72.44%

runtime/moonbeam/src/governance/tracks.rs Outdated Show resolved Hide resolved
runtime/moonbeam/src/governance/tracks.rs Outdated Show resolved Hide resolved
runtime/moonbeam/src/governance/tracks.rs Outdated Show resolved Hide resolved
runtime/moonbeam/src/governance/tracks.rs Outdated Show resolved Hide resolved
runtime/moonbeam/src/governance/tracks.rs Outdated Show resolved Hide resolved
fgamundi and others added 7 commits May 16, 2023 11:14
Co-authored-by: Alan Sapede <alan@purestake.com>
Co-authored-by: Alan Sapede <alan@purestake.com>
Co-authored-by: Alan Sapede <alan@purestake.com>
Co-authored-by: Alan Sapede <alan@purestake.com>
Co-authored-by: Alan Sapede <alan@purestake.com>
@fgamundi fgamundi added the A0-pleasereview Pull request needs code review. label May 18, 2023
@fgamundi fgamundi merged commit 19fc083 into master May 24, 2023
26 checks passed
@fgamundi fgamundi deleted the fg-opengov-moonbeam branch May 24, 2023 08:26
timbrinded pushed a commit that referenced this pull request Jun 2, 2023
* First pass at setting up OpenGov for Moonbeam

* Integration tests w/o OpenTechCommitteeCollective

* GeneralAdmin as origin. OpenTechCommitteeInstance council

* Updated headers

* Set OpenTechCommitteeInstance as whitelist origin

* Update runtime/moonbeam/src/governance/tracks.rs

Co-authored-by: Alan Sapede <alan@purestake.com>

* Update runtime/moonbeam/src/governance/tracks.rs

Co-authored-by: Alan Sapede <alan@purestake.com>

* Update runtime/moonbeam/src/governance/tracks.rs

Co-authored-by: Alan Sapede <alan@purestake.com>

* Update runtime/moonbeam/src/governance/tracks.rs

Co-authored-by: Alan Sapede <alan@purestake.com>

* Update runtime/moonbeam/src/governance/tracks.rs

Co-authored-by: Alan Sapede <alan@purestake.com>

* Missing use

---------

Co-authored-by: Alan Sapede <alan@purestake.com>
@crystalin crystalin changed the title OpenGov for Moonbeam Add OpenGov for Moonbeam Jun 9, 2023
@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants