Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate nimbus client-side worker #404

Merged
merged 75 commits into from May 14, 2021
Merged

Integrate nimbus client-side worker #404

merged 75 commits into from May 14, 2021

Conversation

JoshOrndorff
Copy link
Contributor

What does it do?

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

paritytech/cumulus#429

What value does it bring to the blockchain users?

Slot prediction
Keystore integration (no more --author-id except in the dev service)
Session keys rotation

Checklist

  • Does it require a purge of the network?
  • You bumped the runtime version if there are breaking changes in the runtime ?
  • Does it require changes in documentation/tutorials ?

JoshOrndorff and others added 30 commits May 3, 2021 21:02
@JoshOrndorff
Attempt to point to new dependencies. Weird compile errors. Will revi…
a0a8dc0 
…sit tomorrow.
@JoshOrndorff
geting closer
b37ecb1
@JoshOrndorff
More updates to Cargo.lock. Back to weird compile errors.
0a04b63
@JoshOrndorff
patch author inherent (even though it will be pruned soon)
c6c3ac8
@JoshOrndorff
EVM to right version
ac7405c
@JoshOrndorff
Temporarily disable author inherent, to work around some errors.
c2d1699
@JoshOrndorff
change scale codec dep made a difference
f0d2dcf
@JoshOrndorff
Moar progress (reenable author inherent)
345efc2
@JoshOrndorff
tiny comment improvement
8c03178
@JoshOrndorff
Fix pallet mocks
c2ef3ec
@JoshOrndorff
Fix long-standing sudo omission - no noticeable differente though. weird
cb4697d
@JoshOrndorff
It was ParachainSystem that needed Event<T> Thanks @thiolliere
4467989
@JoshOrndorff
runtime compiles
432ad4d
@JoshOrndorff
everything compiles (still some cleanup)
0201056
@JoshOrndorff
Author inherent from nimbus
7a22bfb
@JoshOrndorff
bump cumulonimbus
114d10d
@JoshOrndorff
🎵 bumpity-bump-bump ⛄
a43fb57
@JoshOrndorff
remove rand hack
c76f23f
@JoshOrndorff
Author slot filter from nimbus
66f9093
@JoshOrndorff
Oops, update client-side too
b5d8c5e
@JoshOrndorff
prune dead code and dealias
5da1a77
@JoshOrndorff
Bump some versions and update types so we don't get confused.
7a6b95e
@JoshOrndorff
Implement runtime api (but don't call it yet)
acb46f0
@notlesh
s/author_inherent/pallet_author_inherent/
818eba1
Updates frontier
8286d79
@notlesh
Reflect updated fc-rpc version in test
68dfae2
@notlesh
Merge branch 'master' into notlesh-v0.8-deps-update
50b9b26
@notlesh
Restore missing parens
3572854
@notlesh
Update Cargo.lock
0235ecc
@girazoki
Change fork test behavior. Test now retrieves re-inserted tx at new c… (
01f076b 
#398)

* Change fork test behavior. Test now retrieves re-inserted tx at new canonical chain

* Fix format

* Change let for const
tgmichel and others added 26 commits May 11, 2021 15:31
@tgmichel
Remove sc-transaction-graph
97aa89f
@JoshOrndorff
Update node/Cargo.toml
924f067
@JoshOrndorff
Apply suggestions from code review
00bb58c
@JoshOrndorff
Fix debugging snafu
1ce7baa
@JoshOrndorff
cargo.lock
aa5e589
@JoshOrndorff
prettier
c993cb4
@JoshOrndorff
Fix tools readme
b5bd5e5
@JoshOrndorff
one more for the readme
1d24231
@notlesh
Don't specify fp-rpc version
9f97d27
@JoshOrndorff
resync with dep-update branch
2c14e65
@JoshOrndorff
line length
e539bd6
@JoshOrndorff
fix runtime integration test
84a869d
@JoshOrndorff
Fix typescript integration test
adba2bd
@JoshOrndorff
master.into()
29a9b5f
@JoshOrndorff
bump nimbus
7f1c051
@JoshOrndorff
bump nimbus
9b2f376
@JoshOrndorff
Merge remote-tracking branch 'origin/master' into joshy-total-nimbus
22589be
@JoshOrndorff
Shorten runtime line
b6890a8
@JoshOrndorff
update alphanet spec template
0fb316c
@JoshOrndorff
update stagenet spec template
a9727a0
@JoshOrndorff
⚠️ DISABLE INTEGRATION TESTS ⚠️
c03afbf 
They pass locally, but don't run in CI. I'm disabling them for now so we get a docker image that ops can test.
Restore ts tests
d91fa77
Updates script to use known user keys
76a0538
Improve CI cargo test consistency
39f585c
Change CI to use github runner for non heavy tasks
8d9f1d4
@crystalin
Crystalin 2nd ci fix (#412)
b42f392 
* Reduced spawn time check on ts tests

* Moving rust flag as env variable
@crystalin crystalin merged commit f91699d into master May 14, 2021
@crystalin crystalin deleted the joshy-total-nimbus branch May 14, 2021 16:37
@JoshOrndorff JoshOrndorff mentioned this pull request May 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crystalin crystalin crystalin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JoshOrndorff @crystalin @notlesh @girazoki @tgmichel