Development Dependencies are not excluded as expected

[pseabury]

If I build a package with NuPack and a NuPackExtension, those get included in my BNuget package even though they are marked as development dependencies. I believe this is incorrect.

I think you can fix this by just filtering your dependency scan with :

.Where(_Package => _Package.Id != "NuPack" && !_Package.IsDevelopmentDependency)

That way when I have a library with no real dependencies, consumers aren't pulling a bunch of unnecessary packages. For instance, my library has no real dependencies, and shouldn't need to be published with any NuPack libraries.

<packages>
  <package id="NuGet.CommandLine" version="4.1.0" targetFramework="net462" developmentDependency="true" />
  <package id="NuPack" version="3.4.2" targetFramework="net462" developmentDependency="true" />
  <package id="NuPackPublishExtension" version="1.0.0.25" targetFramework="net462" developmentDependency="true" />
</packages>

Paul

[Puresharper]

right, I will patch it today

[Puresharper]

Sorry didn't found time to do it yesterday. Reported to today.

[Puresharper]

After trying to repair dependencies as expected, I found some issues that force me to change whole dependency detection and management. It took some time and needs to be tetsed with advanced cases to aprove it for release.

NuPack exclusion was present but did not work.
DevelopmentDependency was missing.

[pseabury]

No problem, thanks for looking at it. Currently I'm just manually calling nuget.exe to pack and push my packages.