Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox + Greasemonkey: Settings menu not working #10

Closed
mat926 opened this issue Dec 31, 2020 · 6 comments
Closed

Firefox + Greasemonkey: Settings menu not working #10

mat926 opened this issue Dec 31, 2020 · 6 comments

Comments

@mat926
Copy link

mat926 commented Dec 31, 2020

Firefox 84.0.1 64bit
I cannot open settings from the right-click menu and nothing happens. I tried disabling ad-blocker , disabling other extensions, and re-installing.

@Purfview Purfview changed the title Cannot open settings Firefox + Greasemoney: Settings menu not working Dec 31, 2020
@Purfview Purfview changed the title Firefox + Greasemoney: Settings menu not working Firefox + Greasemonkey: Settings menu not working Dec 31, 2020
@Purfview
Copy link
Owner

Purfview commented Dec 31, 2020

Settings menu works with Greasemonkey and Waterfox, but for some reason doesn't on Firefox.
It works with Violentmonkey/Tampermonkey and all browsers I tested.

Maybe issue of:
greasemonkey/greasemonkey#3078

@poke
Copy link

poke commented Jan 24, 2021

This seems unrelated to the registerMenuCommand function because:

So I would suggest you to bring this up with the GM_config authors because apparently that doesn’t work with GM4.

@poke
Copy link

poke commented Jan 24, 2021

Yes, this is an issue with GM_config and GM4. The following code won’t work with GM4 at the moment:

var iframe = document.createElement('iframe');
iframe.src = 'about:blank';
document.body.appendChild(iframe);
iframe.addEventListener('load', function() {
    console.log('iframe.contentDocument', this.contentDocument); // this is null with GM4
});

But that’s what GM_config uses to render its config screen.

@Purfview
Copy link
Owner

Yes, this is an issue with GM_config and GM4. The following code won’t work with GM4 at the moment:

Strangely, GM_config and GM4 works on Waterfox Classic, GM3 works too.

@poke
Copy link

poke commented Jan 24, 2021

I can only assume that Waterfox doesn’t follow the same-origin rulings for contentDocument in the same way then. GM3 is a very different beast that has little to do with how GM4 works.

@Purfview
Copy link
Owner

Should be fixed now.
Thanks to @poke and @Martii.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants