Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Really low wordcounts for bigger books #62

Closed
Putnam14 opened this issue Feb 17, 2019 · 2 comments
Closed

Really low wordcounts for bigger books #62

Putnam14 opened this issue Feb 17, 2019 · 2 comments
Assignees
@Putnam14
Labels
Back-end bug Something isn't working

Comments

@Putnam14
Copy link
Owner

For some longer books, wordcounts are awfully low. The Big Short says 17 minutes. This ain't right. Maybe put in a check for minutes < page count if the number of pages is over 100? Want to be cognizant of issue #4
@Putnam14 Putnam14 added bug Something isn't working Back-end labels Feb 17, 2019
@Putnam14 Putnam14 mentioned this issue Feb 19, 2019
Closed
@Putnam14 Putnam14 self-assigned this Feb 27, 2019
@Putnam14
Copy link
Owner Author

Changed logic to runtime > pages && (pages < 50 || runtime > pages * 50)

@Putnam14
Copy link
Owner Author

Nevermind, changed to:


      // Check if runtime is realistic (at least half a minute per page for books over 50 pages)
      if (pages < 50 || runtime / pages > 0.5) {

@Putnam14 Putnam14 mentioned this issue Feb 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Putnam14 Putnam14

Labels
Back-end bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Putnam14