Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream.encode should return a list of packets #98

Closed
mikeboers opened this issue May 22, 2015 · 1 comment
Closed

Stream.encode should return a list of packets #98

mikeboers opened this issue May 22, 2015 · 1 comment
Labels
enhancement

Comments

@mikeboers
Copy link
Member

... otherwise the internal buffers will fill (which was the problem at the end of #93). Since this essentially needs to be done, and there is no reason (I can think of) not to, the Stream.encode method should return a list of packets flushing the buffers.
@mikeboers
Copy link
Member Author

Take from #107 that there should be a Stream.encode_one() which maintains the original behavior.

@mikeboers mikeboers mentioned this issue Mar 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mikeboers