Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme #237

Closed
DanHickstein opened this issue Nov 9, 2018 · 4 comments
Closed

Update readme #237

DanHickstein opened this issue Nov 9, 2018 · 4 comments

Comments

@DanHickstein
Copy link
Member

I noticed that the Readme still says that PyAbel required "PyAbel requires Python 2.7 or 3.3-3.5.". Clearly this hasn't been updated in a while.

Also, we might want to update the image with something more interesting, like Fig. 1 from the upcoming paper.

@stggh
Copy link
Collaborator

stggh commented Nov 9, 2018

python version
Good point. IMO it would be nice to drop 2.7 (to save baggage) and move to 3.6+. We may then use f-strings for formatting.

image
Depends on "not published elsewhere" journal requirements.

Can PR #235 be merged? I would like to:
(1) Change three_point to Oliver Haas' #229 version
(2) Update the docs in linbasex (although, I have not yet started this process ...)

@DanHickstein
Copy link
Member Author

I'd say that we give Py2.7 until 2020: https://pythonclock.org/

For the image, we could make some modifications to the image from the paper.

#235 is merged now! I haven't looked to carefully at Oliver Hass' version of three_point - what has changed? Maybe open a new issue on this when you have a chance.

New linbasex docs would be great.

@DanHickstein
Copy link
Member Author

Reading through some journal policies, I would think that including a figure in the PyAbel readme would be acceptable, because the PyAbel github site is not peer reviewed and not copyrighted, so doesn't constitute prior publication. I'd like to include our image in the readme:

pyabel14labels

@DanHickstein
Copy link
Member Author

Okay, these update have been made in #238! :) Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants