Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanups after we support only Python 3.6 or greater #429

Closed
facundobatista opened this issue May 12, 2024 · 0 comments · Fixed by #440
Closed

Cleanups after we support only Python 3.6 or greater #429

facundobatista opened this issue May 12, 2024 · 0 comments · Fixed by #440
Milestone
Release 10

Comments

@facundobatista
Copy link
Member

facundobatista commented May 12, 2024 •
edited
Loading

When #411 lands, we can improve code:

  • Stop declaring constants in fades/init.py:
# Not using http.server.HTTPStatus to support python < 3.5
HTTP_STATUS_NOT_FOUND = 404
HTTP_STATUS_OK = 200
  • There are cleanups in tests/conftest.py (see comments there).
@facundobatista facundobatista added this to the Release 10 milestone May 12, 2024
@facundobatista facundobatista changed the title Stop declaring constants in fades/__init__.py because of old Python Cleanups after we support only Python 3.6 or greater May 12, 2024
@facundobatista facundobatista mentioned this issue Jul 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 10
Development

Successfully merging a pull request may close this issue.

Update different details now we support Py>-3.6 only PyAr/fades
1 participant
@facundobatista