Prevent applying boolean ops to NotImplemented (#1702)

astroid/protocols.py

@@ -78,12 +78,15 @@ def _augmented_name(name):
 
 
 def _infer_unary_op(obj: Any, op: str) -> ConstFactoryResult:
-    """Perform unary operation on object.
+    """Perform unary operation on `obj`, unless it is `NotImplemented`.
 
     Can raise TypeError if operation is unsupported.
     """
-    func = _UNARY_OPERATORS[op]
-    value = func(obj)
+    if obj is NotImplemented:
+        value = obj
+    else:
+        func = _UNARY_OPERATORS[op]
+        value = func(obj)
     return nodes.const_factory(value)
 
 

tests/unittest_inference.py

@@ -1117,6 +1117,12 @@ def __radd__(self, other): return NotImplemented
         first = next(ast_node.infer())
         self.assertEqual(first, util.Uninferable)
 
+    @pytest.mark.filterwarnings("error::DeprecationWarning")
+    def test_binary_op_not_used_in_boolean_context(self) -> None:
+        ast_node = extract_node("not NotImplemented")
+        first = next(ast_node.infer())
+        self.assertIsInstance(first, nodes.Const)
+
     def test_binary_op_list_mul(self) -> None:
         for code in ("a = [[]] * 2", "a = 2 * [[]]"):
             ast = builder.string_build(code, __name__, __file__)