Fix misc type issues (#1884)

astroid/inference.py

@@ -636,13 +636,14 @@ def _infer_old_style_string_formatting(
     TODO: Instead of returning Uninferable we should rely
     on the call to '%' to see if the result is actually uninferable.
     """
-    values = None
     if isinstance(other, nodes.Tuple):
         if util.Uninferable in other.elts:
             return (util.Uninferable,)
         inferred_positional = [helpers.safe_infer(i, context) for i in other.elts]
         if all(isinstance(i, nodes.Const) for i in inferred_positional):
             values = tuple(i.value for i in inferred_positional)
+        else:
+            values = None
     elif isinstance(other, nodes.Dict):
         values: dict[Any, Any] = {}
         for pair in other.items:

astroid/interpreter/objectmodel.py

@@ -142,7 +142,7 @@ def attr___new__(self) -> bases.BoundMethod:
         )
         # We set the parent as being the ClassDef of 'object' as that
         # triggers correct inference as a call to __new__ in bases.py
-        node.parent: nodes.ClassDef = AstroidManager().builtins_module["object"]
+        node.parent = AstroidManager().builtins_module["object"]
 
         return bases.BoundMethod(proxy=node, bound=_get_bound_node(self))
 
@@ -157,7 +157,7 @@ def attr___init__(self) -> bases.BoundMethod:
         )
         # We set the parent as being the ClassDef of 'object' as that
         # is where this method originally comes from
-        node.parent: nodes.ClassDef = AstroidManager().builtins_module["object"]
+        node.parent = AstroidManager().builtins_module["object"]
 
         return bases.BoundMethod(proxy=node, bound=_get_bound_node(self))
 

astroid/nodes/scoped_nodes/mixin.py

@@ -109,7 +109,7 @@ def _append_node(self, child: nodes.NodeNG) -> None:
         # which uses the current class as a mixin or base class.
         # It's rewritten in 2.0, so it makes no sense for now
         # to spend development time on it.
-        self.body.append(child)
+        self.body.append(child)  # type: ignore[attr-defined]
         child.parent = self
 
     @overload

astroid/test_utils.py

@@ -75,5 +75,5 @@ def brainless_manager():
     m.astroid_cache = {}
     m._mod_file_cache = {}
     m._transform = transforms.TransformVisitor()
-    m.extension_package_whitelist = {}
+    m.extension_package_whitelist = set()
     return m