Merge branch 'main' into mandatory-fields

.github/workflows/ci.yaml

@@ -23,7 +23,7 @@ jobs:
         uses: actions/checkout@v3.1.0
       - name: Set up Python ${{ env.DEFAULT_PYTHON }}
         id: python
-        uses: actions/setup-python@v4.3.0
+        uses: actions/setup-python@v4.3.1
         with:
           python-version: ${{ env.DEFAULT_PYTHON }}
           check-latest: true
@@ -86,7 +86,7 @@ jobs:
         uses: actions/checkout@v3.1.0
       - name: Set up Python ${{ matrix.python-version }}
         id: python
-        uses: actions/setup-python@v4.3.0
+        uses: actions/setup-python@v4.3.1
         with:
           python-version: ${{ matrix.python-version }}
           check-latest: true
@@ -142,7 +142,7 @@ jobs:
         uses: actions/checkout@v3.1.0
       - name: Set up Python ${{ matrix.python-version }}
         id: python
-        uses: actions/setup-python@v4.3.0
+        uses: actions/setup-python@v4.3.1
         with:
           python-version: ${{ matrix.python-version }}
           check-latest: true
@@ -191,7 +191,7 @@ jobs:
         uses: actions/checkout@v3.1.0
       - name: Set up Python ${{ matrix.python-version }}
         id: python
-        uses: actions/setup-python@v4.3.0
+        uses: actions/setup-python@v4.3.1
         with:
           python-version: ${{ matrix.python-version }}
           check-latest: true
@@ -235,7 +235,7 @@ jobs:
         uses: actions/checkout@v3.1.0
       - name: Set up Python ${{ matrix.python-version }}
         id: python
-        uses: actions/setup-python@v4.3.0
+        uses: actions/setup-python@v4.3.1
         with:
           python-version: ${{ matrix.python-version }}
           check-latest: true

.github/workflows/release-tests.yml

@@ -16,7 +16,7 @@ jobs:
         uses: actions/checkout@v3.1.0
       - name: Set up Python 3.9
         id: python
-        uses: actions/setup-python@v4.3.0
+        uses: actions/setup-python@v4.3.1
         with:
           # virtualenv 15.1.0 cannot be installed on Python 3.10+
           python-version: 3.9

.github/workflows/release.yml

@@ -23,7 +23,7 @@ jobs:
         uses: actions/checkout@v3.1.0
       - name: Set up Python ${{ env.DEFAULT_PYTHON }}
         id: python
-        uses: actions/setup-python@v4.3.0
+        uses: actions/setup-python@v4.3.1
         with:
           python-version: ${{ env.DEFAULT_PYTHON }}
           check-latest: true

.pre-commit-config.yaml

@@ -3,14 +3,14 @@ ci:
 
 repos:
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.3.0
+    rev: v4.4.0
     hooks:
       - id: trailing-whitespace
         exclude: .github/|tests/testdata
       - id: end-of-file-fixer
         exclude: tests/testdata
   - repo: https://github.com/PyCQA/autoflake
-    rev: v1.7.7
+    rev: v2.0.0
     hooks:
       - id: autoflake
         exclude: tests/testdata|astroid/__init__.py|astroid/scoped_nodes.py|astroid/node_classes.py
@@ -44,7 +44,7 @@ repos:
       - id: black-disable-checker
         exclude: tests/unittest_nodes_lineno.py
   - repo: https://github.com/psf/black
-    rev: 22.10.0
+    rev: 22.12.0
     hooks:
       - id: black
         args: [--safe, --quiet]

ChangeLog

@@ -16,6 +16,22 @@ Release date: TBA
 
   Refs PyCQA/pylint#2567
 
+What's New in astroid 2.12.14?
+==============================
+Release date: TBA
+
+* Handle the effect of properties on the ``__init__`` of a dataclass correctly.
+
+  Closes PyCQA/pylint#5225
+
+* Fix crash if ``numpy`` module doesn't have ``version`` attribute.
+
+  Refs PyCQA/pylint#7868
+
+* Handle ``AttributeError`` during ``str.format`` template inference tip evaluation
+
+  Closes PyCQA/pylint#1902
+
 What's New in astroid 2.12.13?
 ==============================
 Release date: 2022-11-19

astroid/_ast.py

@@ -7,6 +7,7 @@
 import ast
 import sys
 import types
+from collections.abc import Callable
 from functools import partial
 from typing import NamedTuple
 
@@ -36,6 +37,7 @@ class ParserModule(NamedTuple):
     context_classes: dict[type[ast.expr_context], Context]
 
     def parse(self, string: str, type_comments: bool = True) -> ast.Module:
+        parse_func: Callable[[str], ast.Module]
         if self.module is _ast_py3:
             if PY38_PLUS:
                 parse_func = partial(self.module.parse, type_comments=type_comments)

astroid/brain/brain_builtin_inference.py

@@ -164,7 +164,7 @@ def _builtin_filter_predicate(node, builtin_name) -> bool:
     return False
 
 
-def register_builtin_transform(transform, builtin_name):
+def register_builtin_transform(transform, builtin_name) -> None:
     """Register a new transform function for the given *builtin_name*.
 
     The transform function must accept two parameters, a node and
@@ -952,7 +952,8 @@ def _infer_str_format_call(
 
     try:
         formatted_string = format_template.format(*pos_values, **keyword_values)
-    except (IndexError, KeyError, TypeError, ValueError):
+    except (AttributeError, IndexError, KeyError, TypeError, ValueError):
+        # AttributeError: processing a replacement field using the arguments failed
         # IndexError: there are too few arguments to interpolate
         # TypeError: Unsupported format string
         # ValueError: Unknown format code

astroid/brain/brain_dataclasses.py

@@ -243,6 +243,17 @@ def _generate_dataclass_init(
         name, annotation, value = assign.target.name, assign.annotation, assign.value
         assign_names.append(name)
 
+        # Check whether this assign is overriden by a property assignment
+        property_node: nodes.FunctionDef | None = None
+        for additional_assign in node.locals[name]:
+            if not isinstance(additional_assign, nodes.FunctionDef):
+                continue
+            if not additional_assign.decorators:
+                continue
+            if "builtins.property" in additional_assign.decoratornames():
+                property_node = additional_assign
+                break
+
         if _is_init_var(annotation):  # type: ignore[arg-type] # annotation is never None
             init_var = True
             if isinstance(annotation, nodes.Subscript):
@@ -277,6 +288,14 @@ def _generate_dataclass_init(
                         )
             else:
                 param_str += f" = {value.as_string()}"
+        elif property_node:
+            # We set the result of the property call as default
+            # This hides the fact that this would normally be a 'property object'
+            # But we can't represent those as string
+            try:
+                param_str += f" = {next(property_node.infer_call_result()).as_string()}"
+            except (InferenceError, StopIteration):
+                pass
 
         params.append(param_str)
         if not init_var:

astroid/brain/brain_numpy_utils.py

@@ -31,7 +31,7 @@ def _get_numpy_version() -> tuple[str, str, str]:
         import numpy  # pylint: disable=import-outside-toplevel
 
         return tuple(numpy.version.version.split("."))
-    except ImportError:
+    except (ImportError, AttributeError):
         return ("0", "0", "0")
 
 

astroid/brain/brain_uuid.py

@@ -8,7 +8,7 @@
 from astroid.nodes.scoped_nodes import ClassDef
 
 
-def _patch_uuid_class(node):
+def _patch_uuid_class(node: ClassDef) -> None:
     # The .int member is patched using __dict__
     node.locals["int"] = [Const(0, parent=node)]
 

astroid/brain/helpers.py

@@ -2,11 +2,18 @@
 # For details: https://github.com/PyCQA/astroid/blob/main/LICENSE
 # Copyright (c) https://github.com/PyCQA/astroid/blob/main/CONTRIBUTORS.txt
 
+from __future__ import annotations
+
+from collections.abc import Callable
+
+from astroid.manager import AstroidManager
 from astroid.nodes.scoped_nodes import Module
 
 
-def register_module_extender(manager, module_name, get_extension_mod):
-    def transform(node):
+def register_module_extender(
+    manager: AstroidManager, module_name: str, get_extension_mod: Callable[[], Module]
+) -> None:
+    def transform(node: Module) -> None:
         extension_module = get_extension_mod()
         for name, objs in extension_module.locals.items():
             node.locals[name] = objs

astroid/decorators.py

@@ -10,7 +10,7 @@
 import inspect
 import sys
 import warnings
-from collections.abc import Callable
+from collections.abc import Callable, Generator
 from typing import TypeVar
 
 import wrapt
@@ -97,7 +97,9 @@ def path_wrapper(func):
     """
 
     @functools.wraps(func)
-    def wrapped(node, context: InferenceContext | None = None, _func=func, **kwargs):
+    def wrapped(
+        node, context: InferenceContext | None = None, _func=func, **kwargs
+    ) -> Generator:
         """wrapper function handling context"""
         if context is None:
             context = InferenceContext()