Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO list for Python 3.11 support #1516

Closed
5 tasks done
DanielNoord opened this issue Apr 17, 2022 · 7 comments · Fixed by #2028
Closed
5 tasks done

TODO list for Python 3.11 support #1516

DanielNoord opened this issue Apr 17, 2022 · 7 comments · Fixed by #2028

Comments

@DanielNoord
Copy link
Collaborator

DanielNoord commented Apr 17, 2022

@DanielNoord DanielNoord added this to the 2.13.0 milestone Apr 17, 2022
@cdce8p
Copy link
Member

cdce8p commented Apr 22, 2022

Some recent AST changes:

@rkhwaja
Copy link

rkhwaja commented Jul 31, 2022

The wrapt dependency needs to be ">=1.14" for python 3.11. See changelog

@Pierre-Sassoulas
Copy link
Member

@rkhwaja I think pip handle that, if pylint require wrapt >= 1.12 but python 3.11 require wrapt >= 1.14 then pip download >= 1.14. We should not change our lower bound, as we could imagine that wrapt >=1.14 is incompatible with python 3.7 and changing this would break pylint for python 3.7.

@rkhwaja
Copy link

rkhwaja commented Aug 2, 2022

You could add a dependency like "wrapt>=1.14,<2;python_version>='3.11'" and then both the old and the new python will work.

I don't know if you have other users than pylint but they would all just work too if you did it this way.

@Pierre-Sassoulas
Copy link
Member

But is this required at all ? wrapt is the package that should handle the metadata about the pytho interpreters it supports and pip takes it into account.

@cdce8p
Copy link
Member

cdce8p commented Aug 19, 2022

But is this required at all ? wrapt is the package that should handle the metadata about the pytho interpreters it supports and pip takes it into account.

Took me a moment to understand the issue. wrap doesn't pin a max supported version (which is the recommendation). Thus pip will happily install 1.12 even on python 3.11 if the dependency resolution requires it. However, only 1.14 is compatible. The options

  • Add wrapt>=1.14,<2;python_version>='3.11' like @rkhwaja suggested
  • Or just bump the min requirement to 1.14. 1.14 is compatible with Python >=3.5 so that wouldn't be an issue.
  • End-users can always add the wrapt>=1.14 constraint themselves. Although that won't fix existing environments.

@DanielNoord DanielNoord mentioned this issue Aug 21, 2022
2 tasks
@DanielNoord
Copy link
Collaborator Author

  • Or just bump the min requirement to 1.14. 1.14 is compatible with Python >=3.5 so that wouldn't be an issue.

See #1745

@Pierre-Sassoulas Pierre-Sassoulas modified the milestones: 2.13.0, 2.14.0 Nov 30, 2022
@cdce8p cdce8p modified the milestones: 2.14.0, 2.15.0 Jan 30, 2023
Pierre-Sassoulas added a commit that referenced this issue Mar 5, 2023
Visit child nodes of TryStar

Test children

Avoid creating TryExcept under TryStar

block range tests

Proper coverage of block_range in try star node

Add text for name lookup

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
Pierre-Sassoulas added a commit that referenced this issue Mar 5, 2023
Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants