calling parent on a node that is part of a type comment returns the (original) _ast module's FunctionDef

[ltcmelo]

Consider this snippet:

def f(s):
    # type: (str) -> int
    return 42

Given the node from the type comment, Name.int(name='int'), if I call its parent (i.e., node.parent), I get the original _ast module's FunctionDef, instead of astroid's FunctionDef.

[PCManticore]

Hi, thanks for the report. I tried to reproduce this but I was not able, can you paste the exact code you used to demonstrate the issue?

[ltcmelo]

@PCManticore, reproducibility of this one is straightforward to me, here's a (partial) example — but note that I had a typo in the original snippet: I missed the colon after type, which I just fixed; perhaps this is the reason you couldn't reproduce?

Assume an AST visitor with:

def visit_functiondef(self, node: nodes.FunctionDef)
   print(f'the parent of type comment return is {node.type_comment_returns.parent}')

To me, this prints:

[AWhetter]

I've just hit this myself. Here's what I did to reproduce:

>>> import astroid
>>> f = astroid.extract_node("""
def f(a):
    # type: (A) -> None
    pass
""")
>>> f.type_comment_args[0].parent
<ast.FunctionDef object at 0x7f0b0fb077f0>

[PCManticore]

Thanks @AWhetter and @ltcmelo