Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle the effect of kw_only=True in dataclass fields correctly #1899

Merged
merged 1 commit into from
Dec 26, 2022
Merged

Handle the effect of kw_only=True in dataclass fields correctly #1899

merged 1 commit into from
Dec 26, 2022

Conversation

DanielNoord
Copy link
Collaborator

@DanielNoord DanielNoord commented Dec 7, 2022 •
edited

Steps

  • For new features or bug fixes, add a ChangeLog entry describing what your PR does.
  • Write a good description on what the PR does.

Description

Closes pylint-dev/pylint#7623
Closes #1830

Blocked by #1898 as it builds on that refactor.

Type of Changes

Type
✓ 🐛 Bug fix

@DanielNoord DanielNoord added this to the 2.12.14 milestone Dec 7, 2022
@coveralls
Copy link

coveralls commented Dec 7, 2022 •
edited

Pull Request Test Coverage Report for Build 3784014325

  • 16 of 16 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 92.32%
Totals Coverage Status
Change from base Build 3784009559: 0.02%
Covered Lines: 9929
Relevant Lines: 10755
💛 - Coveralls

Pierre-Sassoulas
Pierre-Sassoulas reviewed Dec 24, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'm weary of touching the dataclass code, maybe de could release an alpha to run the primer on ? Or maybe simply on a tag ?

@DanielNoord
Copy link
Collaborator Author

I'll do an alpha release or manual primer test when I we can release this. I want to have a final look at the open dataclass issues and see if I can slip some fixes in. That process was a bit blocked on these two PRs getting merged!

@DanielNoord DanielNoord changed the title Dataclasses/inheritance Handle the effect of kw_only=True in dataclass fields correctly. Dec 26, 2022
@DanielNoord DanielNoord changed the title Handle the effect of kw_only=True in dataclass fields correctly. Handle the effect of kw_only=True in dataclass fields correctly Dec 26, 2022
@DanielNoord DanielNoord merged commit 406dfbc into pylint-dev:main Dec 26, 2022
@DanielNoord DanielNoord deleted the dataclasses/inheritance branch December 26, 2022 23:33
@github-actions github-actions bot mentioned this pull request Dec 26, 2022
Merged
@cdce8p cdce8p added the backported Assigned once the backport is done label Jan 31, 2023
@DanielNoord DanielNoord mentioned this pull request Feb 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas left review comments

Assignees
No one assigned
Labels
backported Assigned once the backport is done Bug 🪳 dataclasses
Projects
None yet
Milestone
2.12.14
Development

Successfully merging this pull request may close these issues.

[Bug] Issue with inherited keyword dataclass fields kw_only argument of dataclasses.field is not supported
4 participants
@DanielNoord @coveralls @Pierre-Sassoulas @cdce8p