New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regex brain #1934
Regex brain #1934
Conversation
Pull Request Test Coverage Report for Build 3824990210
💛 - Coveralls |
Thanks @DanielNoord. I'm unfamiliar with the astroid code and barely function trying to get patches set up the way the core Python folks want things. It never occurred to me that anyone might want to push anything to my fork. I'm sure I forgot to tweak some setting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just adding a little link in the doc.
@Pierre-Sassoulas Do you have a good idea on how to shorten the link? |
I'll wait with merging for the |
for more information, see https://pre-commit.ci
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
for more information, see https://pre-commit.ci
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
ebb3e23
to
e285714
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1934 +/- ##
==========================================
+ Coverage 92.56% 92.58% +0.01%
==========================================
Files 92 93 +1
Lines 10763 10782 +19
==========================================
+ Hits 9963 9982 +19
Misses 800 800
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Steps
Description
Supersedes #1929.
Refs #1911
Closes #1911
@smontanaro I wasn't able to push to your branch so I had to create a new PR. This should be enough to get the flags to work.
Type of Changes