Add flake8 in pre-commit configuration #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
force-pushed
the
add-flake8-in-pre-commit-configuration
branch
from
1180dbd
to
50785f0
Compare
Pierre-Sassoulas
force-pushed
the
add-flake8-in-pre-commit-configuration
branch
2 times, most recently
from
9296406
to
aa6ea8f
Compare
Pierre-Sassoulas
changed the title
|
Ready, but need #972 to be merged first. |
Pierre-Sassoulas
force-pushed
the
add-flake8-in-pre-commit-configuration
branch
from
aa6ea8f
to
dad2dec
Compare
Pierre-Sassoulas
changed the title
And removed in python 3.
As it is what we want here
Pierre-Sassoulas
force-pushed
the
add-flake8-in-pre-commit-configuration
branch
from
dad2dec
to
f3bae89
Compare
cdce8p
approved these changes
May 1, 2021
This could prevent proper parsing, see https://github.com/PyCQA/astroid/pull/971/files#r624557026 Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the legacy problem with flake8, some of them quite ancient (python 2.6 deprecation!) and add an automated checker in pre-commit configuration.
Type of Changes