Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: v1.7.0 [Community Feedback] #199

Closed
weibullguy opened this issue May 1, 2023 · 6 comments · Fixed by #197
Closed

release: v1.7.0 [Community Feedback] #199

weibullguy opened this issue May 1, 2023 · 6 comments · Fixed by #197
Labels
community feedback Issue is tracking feedback from the docformatter community release Announces and tracks release candidate V: minor Bumps the minor version
Milestone

Comments

@weibullguy
Copy link
Member

weibullguy commented May 1, 2023

Tracker for issues related to release v1.7.0 (see #197). Please report all issues encountered while using the v1.7.0 release candidates here.

Release v1.7.0 includes:

Pre-releases for v1.7.0 are available or release candidates can be installed using pip:

pip install git+https://github.com/pycqa/docformatter@v1.7.0-rc1

where the rc1 would be replaced by the release candidate you'd like to use.

@weibullguy weibullguy added V: minor Bumps the minor version release Announces and tracks release candidate labels May 1, 2023
@weibullguy weibullguy added this to the v1.7.0 milestone May 1, 2023
@github-actions github-actions bot added the fresh This is a new issue label May 1, 2023
@weibullguy weibullguy removed the fresh This is a new issue label May 1, 2023
@weibullguy weibullguy pinned this issue May 1, 2023
@github-actions github-actions bot added the fresh This is a new issue label May 1, 2023
@weibullguy weibullguy removed the fresh This is a new issue label May 1, 2023
@github-actions github-actions bot added the fresh This is a new issue label May 1, 2023
@weibullguy weibullguy removed the fresh This is a new issue label May 1, 2023
@seisman
Copy link

seisman commented May 3, 2023

Please see if this is a bug:

Python code:

def test_docformatter_v1.7.0()
    """
    This is a short desription.

    Here is a link to the github issue
    https://github.com/PyCQA/docformatter/issues/199

    This is a long description.
    """
    pass

Diff output after running docformatter:

$ docformatter --pre-summary-new --make-summary-multi-line test.py       
--- before/test.py
+++ after/test.py
@@ -4,7 +4,7 @@
 
     Here is a link to the github issue
     https://github.com/PyCQA/docformatter/issues/199
-
+    
     This is a long description.
     """
     pass

@weibullguy
Copy link
Member Author

@seisman it is and it's fixed in v1.7.0-rc2.

@weibullguy weibullguy changed the title release: v1.7.0 release: v1.7.0 [Community Feedback] May 3, 2023
@github-actions github-actions bot added the fresh This is a new issue label May 3, 2023
@weibullguy weibullguy added community feedback Issue is tracking feedback from the docformatter community and removed fresh This is a new issue labels May 3, 2023
@seisman
Copy link

seisman commented May 3, 2023

One more potential issue using v1.7.0-rc2:

Code:

def func():
    """
    This is a description.

    Example code::

        config(par=value)

    Example code2::

        with config(par=value) as f:
            pass
    """

Diff output:

$ docformatter --pre-summary-new --make-summary-multi-line test.py
--- before/test.py
+++ after/test.py
@@ -4,10 +4,9 @@
 
     Example code::
 
-        config(par=value)
+    config(par=value)
 
     Example code2::
 
-        with config(par=value) as f:
-            pass
+    with config(par=value) as f:     pass
     """

@weibullguy
Copy link
Member Author

@seisman thanks for the bug hunting. The second one is fixed in v1.7.0-rc3.

@seisman
Copy link

seisman commented May 3, 2023

Now, v1.7.0-rc3 works well for our PyGMT project.

@krzysztof3-wisniewski
Copy link

pre-commit to make sure it doesn't contain any obvious regressions has dedicated test suite which runs it on many open source repositories. Does docformatter have similar test suite? If it doesn't, what do you think about this idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community feedback Issue is tracking feedback from the docformatter community release Announces and tracks release candidate V: minor Bumps the minor version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants